2008-02-22 22:21:55

by Paolo Ciarrocchi

Subject: [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c

File is now error free.
Compile tested.


Signed-off-by: Paolo Ciarrocchi <[email protected]>
---
arch/x86/xen/multicalls.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
index 5e6f36f..5791eb2 100644
--- a/arch/x86/xen/multicalls.c
+++ b/arch/x86/xen/multicalls.c
@@ -76,7 +76,7 @@ void xen_mc_flush(void)
if (ret) {
printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
ret, smp_processor_id());
- for(i = 0; i < b->mcidx; i++) {
+ for (i = 0; i < b->mcidx; i++) {
printk(" call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
i+1, b->mcidx,
b->debug[i].op,
@@ -93,7 +93,7 @@ void xen_mc_flush(void)

local_irq_restore(flags);

- for(i = 0; i < b->cbidx; i++) {
+ for (i = 0; i < b->cbidx; i++) {
struct callback *cb = &b->callbacks[i];

(*cb->fn)(cb->data);
--
1.5.4.GIT

2008-02-22 22:45:35

by Joe Perches

Subject: Re: [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c

On Fri, 2008-02-22 at 23:11 +0100, Paolo Ciarrocchi wrote:
> File is now error free.
> Compile tested.
>
> Signed-off-by: Paolo Ciarrocchi <[email protected]>
> ---
> arch/x86/xen/multicalls.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
> index 5e6f36f..5791eb2 100644
> --- a/arch/x86/xen/multicalls.c
> +++ b/arch/x86/xen/multicalls.c
> @@ -76,7 +76,7 @@ void xen_mc_flush(void)
> if (ret) {
> printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> ret, smp_processor_id());
> - for(i = 0; i < b->mcidx; i++) {
> + for (i = 0; i < b->mcidx; i++) {
> printk(" call %2d/%d: op=%lu arg=[%lx] result=%ld\n",

The printk needs a KERN_ERR prefix

2008-02-23 10:02:08

by Ingo Molnar

Subject: Re: [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c

* Joe Perches <[email protected]> wrote:

> > printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> > ret, smp_processor_id());
> > - for(i = 0; i < b->mcidx; i++) {
> > + for (i = 0; i < b->mcidx; i++) {
> > printk(" call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
>
> The printk needs a KERN_ERR prefix

yes - but we prefer to isolate the "does not change the .o in any way"
cleanups from cleanups that materially change kernel behavior. (such as
printing something else)

Ingo