2008-03-10 21:19:00

by Oleg Nesterov

Subject: [PATCH] signals: cleanup the usage of print_fatal_signal()

Move the callsite of print_fatal_signal() down, under
"if (sig_kernel_coredump(signr))", so we don't need to check signr != SIGKILL.

We are only interested in the sig_kernel_coredump() signals anyway, and due to
the previous changes we almost never can see other fatal signals here except
SIGKILL.

Signed-off-by: Oleg Nesterov <[email protected]>

--- 25/kernel/signal.c~PFS_CLEANUP 2008-03-10 00:47:21.000000000 +0300
+++ 25/kernel/signal.c 2008-03-10 23:55:07.000000000 +0300
@@ -1766,9 +1766,10 @@ relock:
* Anything else is fatal, maybe with a core dump.
*/
current->flags |= PF_SIGNALED;
- if ((signr != SIGKILL) && print_fatal_signals)
- print_fatal_signal(regs, signr);
+
if (sig_kernel_coredump(signr)) {
+ if (print_fatal_signals)
+ print_fatal_signal(regs, signr);
/*
* If it was able to dump core, this kills all
* other threads in the group and synchronizes with

2008-03-11 02:20:36

by Roland McGrath

Subject: Re: [PATCH] signals: cleanup the usage of print_fatal_signal()

Looks right to me. I'd prefer to see a comment before the added lines
and a blank line after them, though.


Thanks,
Roland