This set of five patches moves XPC and XPNET to drivers/misc/xp in preparation
for enabling X86_64 support.
On Tue, Mar 25, 2008 at 02:25:24PM -0500, [email protected] wrote:
> This set of five patches moves XPC and XPNET to drivers/misc/xp in preparation
> for enabling X86_64 support.
It looks like the 2nd patch of this set has been blocked from the mailing
list because of its size. At least that's my assumption. The size of the
five patches are as follows (listed in patch order):
-rw-r--r-- 1 dcn os1 4880 2008-03-25 14:05 uncached-pages
-rw-r--r-- 1 dcn os1 471050 2008-03-25 14:10 move-xp
-rw-r--r-- 1 dcn os1 203046 2008-03-25 14:14 generic-xp
-rw-r--r-- 1 dcn os1 163868 2008-03-25 14:17 Lindent
-rw-r--r-- 1 dcn os1 49723 2008-03-25 14:46 checkpatch.pl
The missing patch moved XPC and XPNET from arch/ia64/sn to drivers/misc/xp.
How should such a patch be submitted?
Thanks,
Dean
On Tue, Mar 25, 2008 at 02:25:24PM -0500, [email protected] wrote:
> This set of five patches moves XPC and XPNET to drivers/misc/xp in preparation
> for enabling X86_64 support.
Part 2 (which I got since you addressed it to me directly as well as
to the list) has a couple of "Space in indent is follwed by a tab"
complaints from GIT. Part 3 has one too. Apart from that all five
parts apply and the build is clean on all my configs. Boots on the
tiger (but this doesn't constitute a review ... just a "you didn't
break anything unrelated while making this change").
> The missing patch moved XPC and XPNET from arch/ia64/sn to drivers/misc/xp.
> How should such a patch be submitted?
I think git has an option to produce its own brand of diff output
that lists the renames without doing a full remove & add which is
needed for patch(1) comprehensibility. A few minutes staring at
git documentation hasn't revealed what that option is though :-(
For purposes of getting someone to review ... you could hand edit
to show the renames as:
$ mv arch/ia64/sn/kernel/xpc_channel.c drivers/misc/xp/xpc_channel.c
... etc.
and just include the diffs for the Makefiles, Kconfig etc.
Or break part 2 into:
2a - remove driver from arch/ia64
2b - add driver to drivers/misc/xp
-Tony
"Luck, Tony" <[email protected]> writes:
> I think git has an option to produce its own brand of diff output
> that lists the renames without doing a full remove & add which is
> needed for patch(1) comprehensibility. A few minutes staring at
> git documentation hasn't revealed what that option is though :-(
$ git diff -M
or "git config --global diff.renames true" to make it permanent.
Andreas.
--
Andreas Schwab, SuSE Labs, [email protected]
SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."