Commit 7d01b475ab17018756c8df27c2ee3c220fab05f8
(Blackfin Serial Driver: Enable IR function when user application)
causes the following build error:
<-- snip -->
...
CC drivers/serial/bfin_5xx.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_init':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1209: error: 'struct tty_driver' has no member named 'set_ldisc'
make[3]: *** [drivers/serial/bfin_5xx.o] Error 1
<-- snip -->
In case it can't be fixed quickly a revert might be an option for 2.6.26.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Sat, Jun 7, 2008 at 12:22 AM, Adrian Bunk <[email protected]> wrote:
> Commit 7d01b475ab17018756c8df27c2ee3c220fab05f8
> (Blackfin Serial Driver: Enable IR function when user application)
> causes the following build error:
>
> <-- snip -->
>
> ...
> CC drivers/serial/bfin_5xx.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_init':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1209: error: 'struct tty_driver' has no member named 'set_ldisc'
> make[3]: *** [drivers/serial/bfin_5xx.o] Error 1
>
> <-- snip -->
>
> In case it can't be fixed quickly a revert might be an option for 2.6.26.
>
Graf has already sent me a patch to fix this. After I test it on my
board, I will send it out for Linus git pull.
Thanks a lot
-Bryan
On Fri, Jun 6, 2008 at 12:40 PM, Bryan Wu <[email protected]> wrote:
> On Sat, Jun 7, 2008 at 12:22 AM, Adrian Bunk <[email protected]> wrote:
>> Commit 7d01b475ab17018756c8df27c2ee3c220fab05f8
>> (Blackfin Serial Driver: Enable IR function when user application)
>> causes the following build error:
>>
>> <-- snip -->
>>
>> ...
>> CC drivers/serial/bfin_5xx.o
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_init':
>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1209: error: 'struct tty_driver' has no member named 'set_ldisc'
>> make[3]: *** [drivers/serial/bfin_5xx.o] Error 1
>>
>> <-- snip -->
>>
>> In case it can't be fixed quickly a revert might be an option for 2.6.26.
>>
>
> Graf has already sent me a patch to fix this. After I test it on my
> board, I will send it out for Linus git pull.
i dont think there's anything for us to do on our side. i thought
Alan was sending the fix out for 2.6.26.
-mike
> In case it can't be fixed quickly a revert might be an option for 2.6.26.
A revert wouldn't be an option as quick check would show you.
The needed enabler patch went into Linus tree so the other fix should
follow before 2.6.26 and all will be well.
Alan
On Sat, Jun 7, 2008 at 3:53 AM, Mike Frysinger <[email protected]> wrote:
> On Fri, Jun 6, 2008 at 12:40 PM, Bryan Wu <[email protected]> wrote:
>> On Sat, Jun 7, 2008 at 12:22 AM, Adrian Bunk <[email protected]> wrote:
>>> Commit 7d01b475ab17018756c8df27c2ee3c220fab05f8
>>> (Blackfin Serial Driver: Enable IR function when user application)
>>> causes the following build error:
>>>
>>> <-- snip -->
>>>
>>> ...
>>> CC drivers/serial/bfin_5xx.o
>>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c: In function 'bfin_serial_init':
>>> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/serial/bfin_5xx.c:1209: error: 'struct tty_driver' has no member named 'set_ldisc'
>>> make[3]: *** [drivers/serial/bfin_5xx.o] Error 1
>>>
>>> <-- snip -->
>>>
>>> In case it can't be fixed quickly a revert might be an option for 2.6.26.
>>>
>>
>> Graf has already sent me a patch to fix this. After I test it on my
>> board, I will send it out for Linus git pull.
>
> i dont think there's anything for us to do on our side. i thought
> Alan was sending the fix out for 2.6.26.
> -mike
>
Oh, no. Even with Alan and Linus pathc, we still need to fix some API change.
I will send it out soon.
-Bryan