2008-06-19 00:39:22

by Kent Liu

Subject: Don't calculate vm_total_pages twice when rebuild zonelists in online_pages()

If zonelist is required to be rebuilt in online_pages(), there is no need
to recalculate vm_total_pages in that function, as it has been updated
in the call build_all_zonelists().

Signed-off-by: Kent Liu <[email protected]>
Acked-by: KAMEZAWA Hiroyuki <[email protected]>

---
mm/memory_hotplug.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 833f854..896ddaf 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -429,7 +429,9 @@ int online_pages(unsigned long pfn, unsigned long nr_pages)

if (need_zonelists_rebuild)
build_all_zonelists();
- vm_total_pages = nr_free_pagecache_pages();
+ else
+ vm_total_pages = nr_free_pagecache_pages();
+
writeback_set_ratelimit();

if (onlined_pages)

2008-06-20 04:10:25

by Kent Liu

Subject: [PATCH]Don't calculate vm_total_pages twice when rebuild zonelists in online_pages()

Resend the patch with more appropriate subject -- adding [PATCH] prefix.
Please consider it.

-----
If zonelist is required to be rebuilt in online_pages(), there is no need
to recalculate vm_total_pages in that function, as it has been updated
in the call build_all_zonelists().

Signed-off-by: Kent Liu <[email protected]>
Acked-by: KAMEZAWA Hiroyuki <[email protected]>

---
mm/memory_hotplug.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 833f854..896ddaf 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -429,7 +429,9 @@ int online_pages(unsigned long pfn, unsigned long nr_pages)

if (need_zonelists_rebuild)
build_all_zonelists();
- vm_total_pages = nr_free_pagecache_pages();
+ else
+ vm_total_pages = nr_free_pagecache_pages();
+
writeback_set_ratelimit();

if (onlined_pages)