2008-07-01 11:56:48

by Adrian Bunk

[permalink] [raw]
Subject: m68k input/ff-core.c build error

Commit 656acd2bbc4ce7f224de499ee255698701396c48
(Input: fix locking in force-feedback core)
causes the following build error on m68k:

<-- snip -->

...
CC drivers/input/ff-core.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c: In function 'input_ff_upload':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c:172: error: dereferencing pointer to incomplete type
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c: In function 'erase_effect':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c:197: error: dereferencing pointer to incomplete type
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c:204: error: dereferencing pointer to incomplete type
make[3]: *** [drivers/input/ff-core.o] Error 1

<-- snip -->

Not sure what exactly the problem is, the failures are the
added spin_unlock_irq(&dev->event_lock)'s.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed


2008-07-01 11:59:18

by Adrian Bunk

[permalink] [raw]
Subject: Re: m68k input/ff-core.c build error

On Tue, Jul 01, 2008 at 02:56:19PM +0300, Adrian Bunk wrote:
> Commit 656acd2bbc4ce7f224de499ee255698701396c48
> (Input: fix locking in force-feedback core)
> causes the following build error on m68k:
>
> <-- snip -->
>
> ...
> CC drivers/input/ff-core.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c: In function 'input_ff_upload':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c:172: error: dereferencing pointer to incomplete type
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c: In function 'erase_effect':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c:197: error: dereferencing pointer to incomplete type
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c:204: error: dereferencing pointer to incomplete type
> make[3]: *** [drivers/input/ff-core.o] Error 1
>
> <-- snip -->
>
> Not sure what exactly the problem is, the failures are the
> added spin_unlock_irq(&dev->event_lock)'s.

And just before I send my email Geert already sends a fix...

:-)

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed