2008-07-31 08:30:11

by Krzysztof Helt

[permalink] [raw]
Subject: Re: [Linux-fbdev-devel] [PATCH] atyfb_base.c: fix warning

> On Wed, Jul 30, 2008 at 5:03 PM, Alexander Beregalov
> <[email protected]> wrote:
> > From: Alexander Beregalov <[email protected]>
> >
> > atyfb_base.c: fix warning
> >
> > drivers/video/aty/atyfb_base.c:2663: warning: 'aty_resume_chip' defined
> > but not used
> >
> > Signed-off-by: Alexander Beregalov <[email protected]>
> > Cc: Ville Syrjala <[email protected]>
> > Cc: Antonino A. Daplas <[email protected]>
>
> Looks good, should you maybe move the aty_resume_chip() up into the
> existing #if defined(CONFIG_PM) &&... that atyfb_pci_resume() is in?
> Not sure, just a thought.
>

The same thought has crossed my mind. Kill the forward declaration and move this short function before atyfb_pci_resume().

Regards,
Krzysztof


----------------------------------------------------------------------
W kosciele tez zdarzaja sie wpadki!
Smieszny filmik >>> http://link.interia.pl/f1e61