2008-07-21 19:34:14

by Adrian Bunk

Subject: [2.6 patch] xen-blkfront.c: make blkif_ioctl() static

This patch makes the needlessly global blkif_ioctl() static.

Signed-off-by: Adrian Bunk <[email protected]>

---
c3e35790145bb28443ccb672fb46318e845c5f05
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 9ae05c5..3ca643c 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -154,8 +154,8 @@ static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
return 0;
}

-int blkif_ioctl(struct inode *inode, struct file *filep,
- unsigned command, unsigned long argument)
+static int blkif_ioctl(struct inode *inode, struct file *filep,
+ unsigned command, unsigned long argument)
{
struct blkfront_info *info =
inode->i_bdev->bd_disk->private_data;

2008-07-21 21:03:53

by Jeremy Fitzhardinge

Subject: Re: [2.6 patch] xen-blkfront.c: make blkif_ioctl() static

Adrian Bunk wrote:
> This patch makes the needlessly global blkif_ioctl() static.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
Acked-by: Jeremy Fitzhardinge <[email protected]>

> ---
> c3e35790145bb28443ccb672fb46318e845c5f05
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 9ae05c5..3ca643c 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -154,8 +154,8 @@ static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
> return 0;
> }
>
> -int blkif_ioctl(struct inode *inode, struct file *filep,
> - unsigned command, unsigned long argument)
> +static int blkif_ioctl(struct inode *inode, struct file *filep,
> + unsigned command, unsigned long argument)
> {
> struct blkfront_info *info =
> inode->i_bdev->bd_disk->private_data;
>
>

2008-08-04 10:00:56

by Jens Axboe

Subject: Re: [2.6 patch] xen-blkfront.c: make blkif_ioctl() static

On Mon, Jul 21 2008, Jeremy Fitzhardinge wrote:
> Adrian Bunk wrote:
> >This patch makes the needlessly global blkif_ioctl() static.
> >
> >Signed-off-by: Adrian Bunk <[email protected]>
> >
> Acked-by: Jeremy Fitzhardinge <[email protected]>

Applied to block tree, thanks.

--
Jens Axboe