2008-08-06 15:38:58

by Peter Oruba

[permalink] [raw]
Subject: [patch 0/5] x86-microcode: run ucode update via workqueue

Referring to: http://lkml.org/lkml/2008/8/3/114
Dmitry, thanks for your work.

Rebased Dmitry's patch set to x86-microcode and incorporated changes into AMD microcode patch loader. No issues with
cpu-hotplug anymore, tested on Intel as well as AMD.

--Peter




2008-08-06 20:14:58

by Dmitry Adamushko

[permalink] [raw]
Subject: Re: [patch 0/5] x86-microcode: run ucode update via workqueue

Hi Peter,

>
> Rebased Dmitry's patch set to x86-microcode and incorporated changes into AMD microcode patch loader. No issues with
> cpu-hotplug anymore, tested on Intel as well as AMD.

btw., I still think we should consider running ucode-updates from the
low-level arch code. But as it's perhaps a material for .28, there
should be plenty of time. I also have in mind a few possible
generalizations/improvemets.
I'll base them on top of your recent patches.


>
> --Peter
>

--
Best regards,
Dmitry Adamushko

2008-08-06 20:35:44

by Max Krasnyansky

[permalink] [raw]
Subject: Re: [patch 0/5] x86-microcode: run ucode update via workqueue

Dmitry Adamushko wrote:
> Hi Peter,
>
>> Rebased Dmitry's patch set to x86-microcode and incorporated changes into AMD microcode patch loader. No issues with
>> cpu-hotplug anymore, tested on Intel as well as AMD.
>
> btw., I still think we should consider running ucode-updates from the
> low-level arch code. But as it's perhaps a material for .28, there
> should be plenty of time.

That'd be ok. Somehow I think it's not worth the effort though. If the
machine was able to boot to the point that it can run user-space
(request_firmware) with the old microcode it can probably sustain itself
a bit longer while waiting for the workqueue thread to be scheduled.
You probably have more exciting things to do ;-)

The latest patches look ok btw.

Max