2008-10-13 17:20:40

by Adrian Bunk

Subject: [2.6 patch] export genphy_restart_aneg

This patch fixes the following build error caused by
commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
(mv643xx_eth: convert to phylib):

<-- snip -->

...
Building modules, stage 2.
MODPOST 1280 modules
ERROR: "genphy_restart_aneg" [drivers/net/mv643xx_eth.ko] undefined!
...
make[2]: *** [__modpost] Error 1

<-- snip -->


Signed-off-by: Adrian Bunk <[email protected]>

---

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 1716274..f11e900 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -557,6 +557,7 @@ int genphy_restart_aneg(struct phy_device *phydev)

return ctl;
}
+EXPORT_SYMBOL(genphy_restart_aneg);


/**

2008-10-13 18:10:31

by Andy Fleming

Subject: Re: [2.6 patch] export genphy_restart_aneg

On Oct 13, 2008, at 12:19, Adrian Bunk wrote:

> This patch fixes the following build error caused by
> commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
> (mv643xx_eth: convert to phylib):
>
> <-- snip -->
>
> ...
> Building modules, stage 2.
> MODPOST 1280 modules
> ERROR: "genphy_restart_aneg" [drivers/net/mv643xx_eth.ko] undefined!
> ...
> make[2]: *** [__modpost] Error 1
>
> <-- snip -->
>
>
> Signed-off-by: Adrian Bunk <[email protected]>


Could you get genphy_setup_forced, too? It doesn't appear to be used,
but it's currently in include/linux/phy.h, and not static.

Alternatively, we could change genphy_setup_forced to be static. :)

Andy

2008-10-13 18:52:42

by David Miller

Subject: Re: [2.6 patch] export genphy_restart_aneg

From: Andy Fleming <[email protected]>
Date: Mon, 13 Oct 2008 13:04:30 -0500

>
> On Oct 13, 2008, at 12:19, Adrian Bunk wrote:
>
> > This patch fixes the following build error caused by
> > commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
> > (mv643xx_eth: convert to phylib):
> >
> > <-- snip -->
> >
> > ...
> > Building modules, stage 2.
> > MODPOST 1280 modules
> > ERROR: "genphy_restart_aneg" [drivers/net/mv643xx_eth.ko] undefined!
> > ...
> > make[2]: *** [__modpost] Error 1
> >
> > <-- snip -->
> >
> >
> > Signed-off-by: Adrian Bunk <[email protected]>
>
>
> Could you get genphy_setup_forced, too? It doesn't appear to be used, but it's currently in include/linux/phy.h, and not static.

When there is a use we can add the export.

2008-10-14 01:48:54

by David Miller

Subject: Re: [2.6 patch] export genphy_restart_aneg

From: Adrian Bunk <[email protected]>
Date: Mon, 13 Oct 2008 20:19:00 +0300

> This patch fixes the following build error caused by
> commit ed94493fb38a665cebcf750dfabe8a6dd13e136f
> (mv643xx_eth: convert to phylib):

Applied, th anks Adrian.