2008-10-18 13:37:28

by Mariusz Kozlowski

Subject: [PATCH] fix comile error of hdpuftrs

Hello,

drivers/misc/hdpuftrs/hdpu_nexus.c:118: error: expected identifier or '(' before 'return'
drivers/misc/hdpuftrs/hdpu_nexus.c:119: error: expected identifier or '(' before '}' token

Signed-off-by: Mariusz Kozlowski <[email protected]>

--- a/drivers/misc/hdpuftrs/hdpu_nexus.c
+++ b/drivers/misc/hdpuftrs/hdpu_nexus.c
@@ -113,7 +113,6 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
if (!hdpu_chassis_id)
printk(KERN_WARNING "sky_nexus: "
"Unable to create proc dir entry: sky_chassis_id\n");
- }

return 0;
}

2008-10-27 04:24:47

by Andrew Morton

Subject: Re: [PATCH] fix comile error of hdpuftrs

On Sat, 18 Oct 2008 15:37:12 +0200 Mariusz Kozlowski <[email protected]> wrote:

> Hello,
>
> drivers/misc/hdpuftrs/hdpu_nexus.c:118: error: expected identifier or '(' before 'return'
> drivers/misc/hdpuftrs/hdpu_nexus.c:119: error: expected identifier or '(' before '}' token
>
> Signed-off-by: Mariusz Kozlowski <[email protected]>
>
> --- a/drivers/misc/hdpuftrs/hdpu_nexus.c
> +++ b/drivers/misc/hdpuftrs/hdpu_nexus.c
> @@ -113,7 +113,6 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
> if (!hdpu_chassis_id)
> printk(KERN_WARNING "sky_nexus: "
> "Unable to create proc dir entry: sky_chassis_id\n");
> - }
>
> return 0;
> }

This has been broken since 2.6.26.

Nobody noticed because there is no way of enabling CONFIG_HDPU_FEATURES
in Kconfig. I wonder what's up with that.

2008-10-27 21:47:17

by Mariusz Kozlowski

Subject: Re: [PATCH] fix comile error of hdpuftrs

Hi,

> > drivers/misc/hdpuftrs/hdpu_nexus.c:118: error: expected identifier or '(' before 'return'
> > drivers/misc/hdpuftrs/hdpu_nexus.c:119: error: expected identifier or '(' before '}' token
> >
> > Signed-off-by: Mariusz Kozlowski <[email protected]>
> >
> > --- a/drivers/misc/hdpuftrs/hdpu_nexus.c
> > +++ b/drivers/misc/hdpuftrs/hdpu_nexus.c
> > @@ -113,7 +113,6 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
> > if (!hdpu_chassis_id)
> > printk(KERN_WARNING "sky_nexus: "
> > "Unable to create proc dir entry: sky_chassis_id\n");
> > - }
> >
> > return 0;
> > }
>
> This has been broken since 2.6.26.
>
> Nobody noticed because there is no way of enabling CONFIG_HDPU_FEATURES
> in Kconfig. I wonder what's up with that.

Yup. I used simple script to find the brace imbalance. Then I tried to compile it with
make drivers/misc/hdpuftrs/hdpu_nexus.o to verify this.

Mariusz