2008-10-20 23:34:47

by Alex Chiang

Subject: [PATCH] declare vmlist to fix ia64 build breakage in kexec core

Commit acd99dbf54020f5c80b9aa2f2ea86f43cb285b02 (kdump: add
vmlist.addr to vmcoreinfo for x86 vmalloc translation) broke the
ia64 build in this fashion:

kernel/kexec.c: In function `crash_save_vmcoreinfo_init':
kernel/kexec.c:1374: error: `vmlist' undeclared (first use in this function)
kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once
kernel/kexec.c:1374: error: for each function it appears in.)
kernel/kexec.c:1410: error: dereferencing pointer to incomplete type
make[1]: *** [kernel/kexec.o] Error 1

Adding the proper include fixes the build.

Signed-off-by: Alex Chiang <[email protected]>
---
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 777ac45..ac0fde7 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -30,6 +30,7 @@
#include <linux/pm.h>
#include <linux/cpu.h>
#include <linux/console.h>
+#include <linux/vmalloc.h>

#include <asm/page.h>
#include <asm/uaccess.h>

2008-10-20 23:53:16

by Alex Chiang

Subject: Re: [PATCH] declare vmlist to fix ia64 build breakage in kexec core

Oh whoops, I see that Tony Luck already sent a patch for this
directly to Linus.

[Sorry for the noise, but I didn't realize this until I decided
to browse through my lkml folder, as Tony's patch hasn't been
pushed out yet.]

/ac

* Alex Chiang <[email protected]>:
> Commit acd99dbf54020f5c80b9aa2f2ea86f43cb285b02 (kdump: add
> vmlist.addr to vmcoreinfo for x86 vmalloc translation) broke the
> ia64 build in this fashion:
>
> kernel/kexec.c: In function `crash_save_vmcoreinfo_init':
> kernel/kexec.c:1374: error: `vmlist' undeclared (first use in this function)
> kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once
> kernel/kexec.c:1374: error: for each function it appears in.)
> kernel/kexec.c:1410: error: dereferencing pointer to incomplete type
> make[1]: *** [kernel/kexec.o] Error 1
>
> Adding the proper include fixes the build.
>
> Signed-off-by: Alex Chiang <[email protected]>
> ---
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 777ac45..ac0fde7 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -30,6 +30,7 @@
> #include <linux/pm.h>
> #include <linux/cpu.h>
> #include <linux/console.h>
> +#include <linux/vmalloc.h>
>
> #include <asm/page.h>
> #include <asm/uaccess.h>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

2008-10-21 00:37:12

by Ken'ichi Ohmichi

Subject: Re: [PATCH] declare vmlist to fix ia64 build breakage in kexec core

Hi Alex, Tony,

Alex Chiang wrote:
> Oh whoops, I see that Tony Luck already sent a patch for this
> directly to Linus.

Thank you for fixing a bug contained in my patch.


Thanks
Ken'ichi Ohmichi

> [Sorry for the noise, but I didn't realize this until I decided
> to browse through my lkml folder, as Tony's patch hasn't been
> pushed out yet.]
>
> /ac
>
> * Alex Chiang <[email protected]>:
>> Commit acd99dbf54020f5c80b9aa2f2ea86f43cb285b02 (kdump: add
>> vmlist.addr to vmcoreinfo for x86 vmalloc translation) broke the
>> ia64 build in this fashion:
>>
>> kernel/kexec.c: In function `crash_save_vmcoreinfo_init':
>> kernel/kexec.c:1374: error: `vmlist' undeclared (first use in this function)
>> kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once
>> kernel/kexec.c:1374: error: for each function it appears in.)
>> kernel/kexec.c:1410: error: dereferencing pointer to incomplete type
>> make[1]: *** [kernel/kexec.o] Error 1
>>
>> Adding the proper include fixes the build.
>>
>> Signed-off-by: Alex Chiang <[email protected]>
>> ---
>> diff --git a/kernel/kexec.c b/kernel/kexec.c
>> index 777ac45..ac0fde7 100644
>> --- a/kernel/kexec.c
>> +++ b/kernel/kexec.c
>> @@ -30,6 +30,7 @@
>> #include <linux/pm.h>
>> #include <linux/cpu.h>
>> #include <linux/console.h>
>> +#include <linux/vmalloc.h>
>>
>> #include <asm/page.h>
>> #include <asm/uaccess.h>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>