2008-11-03 20:10:29

by Ben Dooks

Subject: [patch 2/7] SDHCI: Print ADMA status and pointer on debug

If using ADMA, then we should print the ADMA error
and current pointer in sdhci_dumpregs() when any
debug is requested.

Signed-off-by: Ben Dooks <[email protected]>

--- linux.git.orig/drivers/mmc/host/sdhci.c 2008-10-27 08:17:43.000000000 +0000
+++ linux.git/drivers/mmc/host/sdhci.c 2008-10-27 11:01:20.000000000 +0000
@@ -73,6 +73,11 @@ static void sdhci_dumpregs(struct sdhci_
readl(host->ioaddr + SDHCI_CAPABILITIES),
readl(host->ioaddr + SDHCI_MAX_CURRENT));

+ if (host->flags & SDHCI_USE_ADMA)
+ printk(KERN_DEBUG DRIVER_NAME ": ADMA Err: 0x%08x | ADMA Ptr: 0x%08x\n",
+ readl(host->ioaddr + SDHCI_ADMA_ERROR),
+ readl(host->ioaddr + SDHCI_ADMA_ADDRESS));
+
printk(KERN_DEBUG DRIVER_NAME ": ===========================================\n");
}


--
Ben ([email protected], http://www.fluff.org/)

'a smiley only costs 4 bytes'

2008-11-14 21:30:11

by Pierre Ossman

Subject: Re: [patch 2/7] SDHCI: Print ADMA status and pointer on debug

On Mon, 03 Nov 2008 20:09:46 +0000
Ben Dooks <[email protected]> wrote:

> If using ADMA, then we should print the ADMA error
> and current pointer in sdhci_dumpregs() when any
> debug is requested.
>
> Signed-off-by: Ben Dooks <[email protected]>
>

Looks ok. I think that dump routine could use some more TLC to be
really useful.

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.