2009-01-01 16:11:50

by sangsu

Subject: [PATCH]USB:Fix goku_udc usb speed handling

The usb gadget framework revealed weakness in the godu_udc
gadget driver register function. Instead of checking if
speed asked for was USB_LOW_SPEED upon usb_gadget_register()
to deny service, it checked only for USB_FULL_SPEED, thus
denying service to usb high speed capable gadgets.

Signed-off-by: SangSu Park<[email protected]>
---
drivers/usb/gadget/goku_udc.c |2+-
1 files changed, 1 insertion(+), 1 deletions(-)


--- a/drivers/usb/gadget/goku_udc.c 2008-12-30 23:24:02.000000000 +0900
+++ b/drivers/usb/gadget/goku_udc.c 2009-01-02 00:49:15.000000000 +0900
@@ -1349,7 +1349,7 @@
int retval;

if (!driver
- || driver->speed != USB_SPEED_FULL
+ || driver->speed < USB_SPEED_FULL
|| !driver->bind
|| !driver->disconnect
|| !driver->setup)

2009-01-05 22:46:21

by David Brownell

Subject: Re: [PATCH]USB:Fix goku_udc usb speed handling

On Thursday 01 January 2009, sangsu wrote:
> The usb gadget framework revealed weakness in the godu_udc
> gadget driver register function. Instead of checking if
> speed asked for was USB_LOW_SPEED upon usb_gadget_register()
> to deny service, it checked only for USB_FULL_SPEED, thus
> denying service to usb high speed capable gadgets.
>
> Signed-off-by: SangSu Park<[email protected]>

Acked-by: David Brownell <[email protected]>


Good to know this USB peripheral driver is getting some use. :)


> ---
> drivers/usb/gadget/goku_udc.c |2+-
> 1 files changed, 1 insertion(+), 1 deletions(-)
>
>
> --- a/drivers/usb/gadget/goku_udc.c 2008-12-30 23:24:02.000000000 +0900
> +++ b/drivers/usb/gadget/goku_udc.c 2009-01-02 00:49:15.000000000 +0900
> @@ -1349,7 +1349,7 @@
> int retval;
>
> if (!driver
> - || driver->speed != USB_SPEED_FULL
> + || driver->speed < USB_SPEED_FULL
> || !driver->bind
> || !driver->disconnect
> || !driver->setup)
>
>