From: Krishna Chaitanya Gudipati <[email protected]>
This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
the code review comments from previous submission.
Signed-off-by: Krishna Chaitanya Gudipati <[email protected]>
---
Kconfig | 9 +++++++++
Makefile | 1 +
bfa/Makefile | 27 +++++++++++++++++++++++++++
3 files changed, 37 insertions(+)
diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
--- orig/drivers/scsi/Kconfig 2009-04-01 20:08:49.271161000 -0700
+++ patch/drivers/scsi/Kconfig 2009-04-01 20:08:44.003822000 -0700
@@ -1797,6 +1797,15 @@ config SCSI_SRP
To compile this driver as a module, choose M here: the
module will be called libsrp.
+config SCSI_BFA_FC
+ tristate "Brocade BFA Fibre Channel Support"
+ depends on PCI && SCSI
+ help
+ This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
+
+ To compile this driver as a module, choose M here. The module will
+ be called bfa.
+
endif # SCSI_LOWLEVEL
source "drivers/scsi/pcmcia/Kconfig"
diff -urpN orig/drivers/scsi/Makefile patch/drivers/scsi/Makefile
--- orig/drivers/scsi/Makefile 2009-04-01 20:08:49.298683000 -0700
+++ patch/drivers/scsi/Makefile 2009-04-01 20:08:44.040005000 -0700
@@ -84,6 +84,7 @@ obj-$(CONFIG_SCSI_QLOGIC_1280) += qla128
obj-$(CONFIG_SCSI_QLA_FC) += qla2xxx/
obj-$(CONFIG_SCSI_QLA_ISCSI) += qla4xxx/
obj-$(CONFIG_SCSI_LPFC) += lpfc/
+obj-$(CONFIG_SCSI_BFA_FC) += bfa/
obj-$(CONFIG_SCSI_PAS16) += pas16.o
obj-$(CONFIG_SCSI_T128) += t128.o
obj-$(CONFIG_SCSI_DMX3191D) += dmx3191d.o
diff -urpN orig/drivers/scsi/bfa/Makefile patch/drivers/scsi/bfa/Makefile
--- orig/drivers/scsi/bfa/Makefile 1969-12-31 16:00:00.000000000 -0800
+++ patch/drivers/scsi/bfa/Makefile 2009-04-01 20:08:49.244443000 -0700
@@ -0,0 +1,27 @@
+#
+# Copyright (c) 2005-2008 Brocade Communications Systems, Inc.
+# All rights reserved
+# http://www.brocade.com
+#
+# Linux driver for Brocade Fibre Channel Host Bus Adapter.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License (GPL) Version 2 as
+# published by the Free Software Foundation
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# General Public License for more details.
+#
+obj-$(CONFIG_SCSI_BFA_FC) := bfa.o
+
+bfa-objs := bfad.o bfad_intr.o bfad_os.o bfad_im.o bfad_attr.o bfad_fwimg.o \
+ bfa_core.o bfa_ioc.o bfa_iocfc.o bfa_fcxp.o \
+ bfa_lps.o bfa_hw_cb.o bfa_hw_ct.o bfa_intr.o bfa_timer.o \
+ bfa_rport.o bfa_port.o bfa_uf.o bfa_sgpg.o bfa_module.o bfa_ioim.o \
+ bfa_itnim.o bfa_fcpim.o bfa_tskim.o bfa_port.o bfa_vport.o \
+ bfa_lport.o bfa_fabric.o bfa_auth.o bfa_vfapi.o \
+ bfa_log.o bfa_log_module.o bfa_csdebug.o bfa_sm.o plog.o
+
+EXTRA_CFLAGS += -I$(obj) -I$(obj)/include
On Wed, 2009-04-01 at 20:35 -0700, Krishna Gudipati wrote:
> From: Krishna Chaitanya Gudipati <[email protected]>
>
> This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
> the code review comments from previous submission.
>
> Signed-off-by: Krishna Chaitanya Gudipati <[email protected]>
> ---
> Kconfig | 9 +++++++++
> Makefile | 1 +
> bfa/Makefile | 27 +++++++++++++++++++++++++++
> 3 files changed, 37 insertions(+)
>
> diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
> --- orig/drivers/scsi/Kconfig 2009-04-01 20:08:49.271161000 -0700
> +++ patch/drivers/scsi/Kconfig 2009-04-01 20:08:44.003822000 -0700
> @@ -1797,6 +1797,15 @@ config SCSI_SRP
> To compile this driver as a module, choose M here: the
> module will be called libsrp.
>
> +config SCSI_BFA_FC
> + tristate "Brocade BFA Fibre Channel Support"
> + depends on PCI && SCSI
> + help
> + This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
> +
> + To compile this driver as a module, choose M here. The module will
> + be called bfa.
> +
You're still not using the FC transport class to export common sysfs FC
information or to help make your driver smaller. I thought you were
going to fix this after this was noted in your first submission to
linux-scsi on 24 September?
James
On Thu, Apr 2, 2009 at 9:36 PM, James Bottomley
<[email protected]> wrote:
> On Wed, 2009-04-01 at 20:35 -0700, Krishna Gudipati wrote:
>> From: Krishna Chaitanya Gudipati <[email protected]>
>>
>> This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
>> the code review comments from previous submission.
>>
>> Signed-off-by: Krishna Chaitanya Gudipati <[email protected]>
>> ---
>> ?Kconfig ? ? ?| ? ?9 +++++++++
>> ?Makefile ? ? | ? ?1 +
>> ?bfa/Makefile | ? 27 +++++++++++++++++++++++++++
>> ?3 files changed, 37 insertions(+)
>>
>> diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
>> --- orig/drivers/scsi/Kconfig 2009-04-01 20:08:49.271161000 -0700
>> +++ patch/drivers/scsi/Kconfig ? ? ? ?2009-04-01 20:08:44.003822000 -0700
>> @@ -1797,6 +1797,15 @@ config SCSI_SRP
>> ? ? ? ? To compile this driver as a module, choose M here: the
>> ? ? ? ? module will be called libsrp.
>>
>> +config SCSI_BFA_FC
>> + ? ? tristate "Brocade BFA Fibre Channel Support"
>> + ? ? depends on PCI && SCSI
>> + ? ? help
>> + ? ? ? This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
>> +
>> + ? ? ? To compile this driver as a module, choose M here. The module will
>> + ? ? ? be called bfa.
>> +
>
> You're still not using the FC transport class to export common sysfs FC
> information or to help make your driver smaller. ?I thought you were
> going to fix this after this was noted in your first submission to
> linux-scsi on 24 September?
>
> James
>
>
Hi James,
We removed Brocade specific sysfs code after first linux-scsi
submission. Can you please
clarify where we are still not using the FC transport class to export
common sysfs FC
information? We do use the fc transport template to create the common
sysfs FC attributes
(in bfad_attr.c) under /sys/class/fc_host/<host#>
Thanks
Jing
On Sat, 2009-04-04 at 20:41 +0800, Jing Huang wrote:
> On Thu, Apr 2, 2009 at 9:36 PM, James Bottomley
> <[email protected]> wrote:
> > On Wed, 2009-04-01 at 20:35 -0700, Krishna Gudipati wrote:
> >> From: Krishna Chaitanya Gudipati <[email protected]>
> >>
> >> This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
> >> the code review comments from previous submission.
> >>
> >> Signed-off-by: Krishna Chaitanya Gudipati <[email protected]>
> >> ---
> >> Kconfig | 9 +++++++++
> >> Makefile | 1 +
> >> bfa/Makefile | 27 +++++++++++++++++++++++++++
> >> 3 files changed, 37 insertions(+)
> >>
> >> diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
> >> --- orig/drivers/scsi/Kconfig 2009-04-01 20:08:49.271161000 -0700
> >> +++ patch/drivers/scsi/Kconfig 2009-04-01 20:08:44.003822000 -0700
> >> @@ -1797,6 +1797,15 @@ config SCSI_SRP
> >> To compile this driver as a module, choose M here: the
> >> module will be called libsrp.
> >>
> >> +config SCSI_BFA_FC
> >> + tristate "Brocade BFA Fibre Channel Support"
> >> + depends on PCI && SCSI
> >> + help
> >> + This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
> >> +
> >> + To compile this driver as a module, choose M here. The module will
> >> + be called bfa.
> >> +
> >
> > You're still not using the FC transport class to export common sysfs FC
> > information or to help make your driver smaller. I thought you were
> > going to fix this after this was noted in your first submission to
> > linux-scsi on 24 September?
> >
> > James
> >
> >
>
> Hi James,
>
> We removed Brocade specific sysfs code after first linux-scsi
> submission. Can you please
> clarify where we are still not using the FC transport class to export
> common sysfs FC
> information? We do use the fc transport template to create the common
> sysfs FC attributes
> (in bfad_attr.c) under /sys/class/fc_host/<host#>
Ah ... I was going by the fact that you don't select SCSI_FC_ATTRS in
the Kconfig ... so this is just something as simple as a missing select?
(Without the select you'll fail some of the random compile tests because
the needed scsi_transport_fc code won't be present).
James