2009-04-15 09:11:46

by Eugene Teo

Subject: [PATCH] Btrfs: setting variable out of order

This doesn't look intentional.

Signed-off-by: Eugene Teo <[email protected]>
---
fs/btrfs/ctree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index e5b2533..6aa2468 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct
btrfs_trans_handle *trans,
for (i = 0; i < nr; i++) {
if (total_size + data_size[i] + sizeof(struct btrfs_item) >
BTRFS_LEAF_DATA_SIZE(root)) {
- break;
nr = i;
+ break;
}
total_data += data_size[i];
total_size += data_size[i] + sizeof(struct btrfs_item);

2009-04-15 12:59:23

by Chris Mason

Subject: Re: [PATCH] Btrfs: setting variable out of order

On Wed, 2009-04-15 at 17:11 +0800, Eugene Teo wrote:
> This doesn't look intentional.
>
> Signed-off-by: Eugene Teo <[email protected]>
> ---
> fs/btrfs/ctree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> index e5b2533..6aa2468 100644
> --- a/fs/btrfs/ctree.c
> +++ b/fs/btrfs/ctree.c
> @@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct
> btrfs_trans_handle *trans,
> for (i = 0; i < nr; i++) {
> if (total_size + data_size[i] + sizeof(struct btrfs_item) >
> BTRFS_LEAF_DATA_SIZE(root)) {
> - break;
> nr = i;
> + break;
> }

Thanks,

This function isn't used anymore, I'll drop it.

-chris