2009-06-03 15:38:26

by Michael S. Zick

[permalink] [raw]
Subject: [RFC: Style] Kernel coding style for Extended Attributes.

Group;

I notice two different styles being used:
__attribute__ (( ....
__attribute__(( ....

The gcc documentation does not make a comment on this,
in fact, the extended attribute doc page uses both. ;)

As a matter of fact, there are macros defined that have
both (not at once) expansions.

Is there a recommended style for the kernel source?

Mike


2009-06-03 15:46:18

by Linus Torvalds

[permalink] [raw]
Subject: Re: [RFC: Style] Kernel coding style for Extended Attributes.



On Wed, 3 Jun 2009, Michael S. Zick wrote:
>
> Is there a recommended style for the kernel source?

I think the recommended style is:

"Hide them behind a macro so that they never show up in the source".

and then basically nobody will care about whether there is a space between
the __attribute__ and '(('.

Linus

2009-06-03 17:11:57

by Michael S. Zick

[permalink] [raw]
Subject: Re: [RFC: Style] Kernel coding style for Extended Attributes.

On Wed June 3 2009, Linus Torvalds wrote:
>
> On Wed, 3 Jun 2009, Michael S. Zick wrote:
> >
> > Is there a recommended style for the kernel source?
>
> I think the recommended style is:
>
> "Hide them behind a macro so that they never show up in the source".
>

That seems to be the general consensus in (/by) practice.

Thanks,
Mike

> and then basically nobody will care about whether there is a space between
> the __attribute__ and '(('.
>
> Linus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>

2009-06-03 19:37:14

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [RFC: Style] Kernel coding style for Extended Attributes.

On Wed, Jun 03, 2009 at 12:11:47PM -0500, Michael S. Zick wrote:
> On Wed June 3 2009, Linus Torvalds wrote:
> >
> > On Wed, 3 Jun 2009, Michael S. Zick wrote:
> > >
> > > Is there a recommended style for the kernel source?
> >
> > I think the recommended style is:
> >
> > "Hide them behind a macro so that they never show up in the source".
> >
>
> That seems to be the general consensus in (/by) practice.

Use __section() to define a section.
See init.h for usage and compiler.h for definition.

Sam