2009-06-11 18:28:55

by Jesse Barnes

[permalink] [raw]
Subject: Re: [PATCH] PCI: eliminate redundant pci_stop_dev() call from pci_destroy_dev()

On Mon, 18 May 2009 19:02:38 -0600
Alex Chiang <[email protected]> wrote:

> We always call pci_stop_bus_device before calling pci_destroy_dev.
>
> Since pci_stop_bus_device calls pci_stop_dev, there is no need
> for pci_destroy_dev to repeat the call.
>
> Signed-off-by: Alex Chiang <[email protected]>
> ---
>
> drivers/pci/remove.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
> index 86503c1..176615e 100644
> --- a/drivers/pci/remove.c
> +++ b/drivers/pci/remove.c
> @@ -32,8 +32,6 @@ static void pci_stop_dev(struct pci_dev *dev)
>
> static void pci_destroy_dev(struct pci_dev *dev)
> {
> - pci_stop_dev(dev);
> -
> /* Remove the device from the device lists, and prevent any
> further
> * list accesses from this device */
> down_write(&pci_bus_sem);

Applied to linux-next, thanks.

--
Jesse Barnes, Intel Open Source Technology Center