2009-07-03 06:39:54

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH -tip] perf tools: gitignore *.data


perf.data made by perf record is a data file and
need to be ignored by git

Added *.data so that perf.data and its friends will be ignored.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
tools/perf/.gitignore | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
index d69a759..057deea 100644
--- a/tools/perf/.gitignore
+++ b/tools/perf/.gitignore
@@ -14,3 +14,4 @@ common-cmds.h
tags
TAGS
cscope*
+*.data
--
1.6.2.5



2009-07-03 10:39:51

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH -tip] perf tools: gitignore *.data


* Jaswinder Singh Rajput <[email protected]> wrote:

> perf.data made by perf record is a data file and need to be
> ignored by git
>
> Added *.data so that perf.data and its friends will be ignored.

> cscope*
> +*.data

ok, this is something i wanted to revisit eventually - the
'perf.data' name sucks a bit - as .data postfix is quite unspecific.

Perhaps trace.perf is a better default name, and all files would
have the .perf postfix?

I've Cc:-ed a number of folks who might have an opinion about this -
what would be the best default naming and postfix for perf binary
files?

Ingo

2009-07-03 13:09:48

by Frederic Weisbecker

[permalink] [raw]
Subject: Re: [PATCH -tip] perf tools: gitignore *.data

On Fri, Jul 03, 2009 at 12:38:52PM +0200, Ingo Molnar wrote:
>
> * Jaswinder Singh Rajput <[email protected]> wrote:
>
> > perf.data made by perf record is a data file and need to be
> > ignored by git
> >
> > Added *.data so that perf.data and its friends will be ignored.
>
> > cscope*
> > +*.data
>
> ok, this is something i wanted to revisit eventually - the
> 'perf.data' name sucks a bit - as .data postfix is quite unspecific.
>
> Perhaps trace.perf is a better default name, and all files would
> have the .perf postfix?
>
> I've Cc:-ed a number of folks who might have an opinion about this -
> what would be the best default naming and postfix for perf binary
> files?
>
> Ingo


perf.bin seems to me adequate as it tells everything (IMHO).

2009-07-03 13:19:19

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH -tip] perf tools: gitignore *.data


* Frederic Weisbecker <[email protected]> wrote:

> On Fri, Jul 03, 2009 at 12:38:52PM +0200, Ingo Molnar wrote:
> >
> > * Jaswinder Singh Rajput <[email protected]> wrote:
> >
> > > perf.data made by perf record is a data file and need to be
> > > ignored by git
> > >
> > > Added *.data so that perf.data and its friends will be ignored.
> >
> > > cscope*
> > > +*.data
> >
> > ok, this is something i wanted to revisit eventually - the
> > 'perf.data' name sucks a bit - as .data postfix is quite unspecific.
> >
> > Perhaps trace.perf is a better default name, and all files would
> > have the .perf postfix?
> >
> > I've Cc:-ed a number of folks who might have an opinion about this -
> > what would be the best default naming and postfix for perf binary
> > files?
> >
> > Ingo
>
> perf.bin seems to me adequate as it tells everything (IMHO).

hm, .bin is pretty overloaded as well. It also suggests a
'executable binary' in a certain way - which it isnt.

Ingo

2009-07-03 14:44:52

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH -tip] perf tools: gitignore *.data

Em Fri, Jul 03, 2009 at 03:18:24PM +0200, Ingo Molnar escreveu:
>
> * Frederic Weisbecker <[email protected]> wrote:
>
> > On Fri, Jul 03, 2009 at 12:38:52PM +0200, Ingo Molnar wrote:
> > >
> > > * Jaswinder Singh Rajput <[email protected]> wrote:
> > >
> > > > perf.data made by perf record is a data file and need to be
> > > > ignored by git
> > > >
> > > > Added *.data so that perf.data and its friends will be ignored.
> > >
> > > > cscope*
> > > > +*.data
> > >
> > > ok, this is something i wanted to revisit eventually - the
> > > 'perf.data' name sucks a bit - as .data postfix is quite unspecific.
> > >
> > > Perhaps trace.perf is a better default name, and all files would
> > > have the .perf postfix?
> > >
> > > I've Cc:-ed a number of folks who might have an opinion about this -
> > > what would be the best default naming and postfix for perf binary
> > > files?
> > >
> > > Ingo
> >
> > perf.bin seems to me adequate as it tells everything (IMHO).
>
> hm, .bin is pretty overloaded as well. It also suggests a
> 'executable binary' in a certain way - which it isnt.

.samples
.perf
.perf_samples
.ps - oops, also used ;-)

- Arnaldo