Hi Mark,
On Tue, Mar 30, 2010 at 03:12:02PM +0100, Mark Brown wrote:
> On Mon, Mar 29, 2010 at 09:28:45PM +0100, Mark Brown wrote:
>
> > + printk(KERN_CRIT "%x %x\n", status[0], status[1]);
>
> Clearly this is debug code and shouldn't be there in an actual version.
> I'll remove this when resubmitting after review & merge path are sorted
> out.
All right, I won't merge it for now.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
On Fri, Apr 02, 2010 at 12:17:55PM +0200, Samuel Ortiz wrote:
> Hi Mark,
>
> On Tue, Mar 30, 2010 at 03:12:02PM +0100, Mark Brown wrote:
> > On Mon, Mar 29, 2010 at 09:28:45PM +0100, Mark Brown wrote:
> >
> > > + printk(KERN_CRIT "%x %x\n", status[0], status[1]);
> >
> > Clearly this is debug code and shouldn't be there in an actual version.
> > I'll remove this when resubmitting after review & merge path are sorted
> > out.
> All right, I won't merge it for now.
Did you see the question in the original posting about where this should
be merged? The bulk of the code using these interrupts will be the
CODEC driver for the device, but the CODEC driver needs to be able to
check if interrupts are set up at all (since commonly CODECs don't have
an IRQ line wired up) so it'd be nice if it were possible to merge via
ASoC.
On Fri, Apr 02, 2010 at 11:24:22AM +0100, Mark Brown wrote:
> On Fri, Apr 02, 2010 at 12:17:55PM +0200, Samuel Ortiz wrote:
> > Hi Mark,
> >
> > On Tue, Mar 30, 2010 at 03:12:02PM +0100, Mark Brown wrote:
> > > On Mon, Mar 29, 2010 at 09:28:45PM +0100, Mark Brown wrote:
> > >
> > > > + printk(KERN_CRIT "%x %x\n", status[0], status[1]);
> > >
> > > Clearly this is debug code and shouldn't be there in an actual version.
> > > I'll remove this when resubmitting after review & merge path are sorted
> > > out.
>
> > All right, I won't merge it for now.
>
> Did you see the question in the original posting about where this should
> be merged?
Sorry, I missed that part.
> The bulk of the code using these interrupts will be the
> CODEC driver for the device, but the CODEC driver needs to be able to
> check if interrupts are set up at all (since commonly CODECs don't have
> an IRQ line wired up) so it'd be nice if it were possible to merge via
> ASoC.
I'm fine with that, please carry this patch. During the next merge window I'll
wait for your code to be merged upstream, fix any potential merge conflicts
and send my pull request.
Also, I had a look at the code and feel free to add my:
Acked-by: Samuel Ortiz <[email protected]>
to it.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
On Fri, Apr 02, 2010 at 01:30:28PM +0200, Samuel Ortiz wrote:
> > The bulk of the code using these interrupts will be the
> > CODEC driver for the device, but the CODEC driver needs to be able to
> > check if interrupts are set up at all (since commonly CODECs don't have
> > an IRQ line wired up) so it'd be nice if it were possible to merge via
> > ASoC.
> I'm fine with that, please carry this patch. During the next merge window I'll
> wait for your code to be merged upstream, fix any potential merge conflicts
> and send my pull request.
Thanks. I'd expect that if things are fine in -next you can probably
not worry about this either way, but given that Takashi normally sends
his pull request very early it probably won't make any difference
anyway.
> Also, I had a look at the code and feel free to add my:
> Acked-by: Samuel Ortiz <[email protected]>
>
> to it.
>
> Cheers,
> Samuel.
>
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/