2010-06-02 04:32:16

by Nobin Mathew

[permalink] [raw]
Subject: make ARM=arm menuconfig problem in mainline

Hi,

The following entry creates problem in ARM System type menu. I am
using a Fedora 12 system.

Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.

config ARCH_S3C2410
??????? bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
S3C2442, S3C2443, S3C2450"
??????? select GENERIC_GPIO
??????? select ARCH_HAS_CPUFREQ
??????? select HAVE_CLK
??????? select ARCH_USES_GETTIMEOFFSET
??????? help
????????? Samsung S3C2410X CPU based systems, such as the Simtec Electronics
????????? BAST (<http://www.simtec.co.uk/products/EB110ITX/>), the IPAQ 1940 or
????????? the Samsung SMDK2410 development board (and derivatives).

????????? Note, the S3C2416 and the S3C2450 are so close that they even share
????????? the same SoC ID code. This means that there is no seperate machine
????????? directory (no arch/arm/mach-s3c2450) as the S3C2416 was first.

Thanks
Nobin


2010-06-02 14:34:32

by Nobin Mathew

[permalink] [raw]
Subject: Re: make ARM=arm menuconfig problem in mainline

adding [email protected]

Hi,

The following entry creates problem in ARM System type menu. I am
using a Fedora 12 system.

Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.

config ARCH_S3C2410
? ? ? ?bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
S3C2442, S3C2443, S3C2450"
? ? ? ?select GENERIC_GPIO
? ? ? ?select ARCH_HAS_CPUFREQ
? ? ? ?select HAVE_CLK
? ? ? ?select ARCH_USES_GETTIMEOFFSET
? ? ? ?help
? ? ? ? ?Samsung S3C2410X CPU based systems, such as the Simtec Electronics
? ? ? ? ?BAST (<http://www.simtec.co.uk/products/EB110ITX/>), the IPAQ 1940 or
? ? ? ? ?the Samsung SMDK2410 development board (and derivatives).

? ? ? ? ?Note, the S3C2416 and the S3C2450 are so close that they even share
? ? ? ? ?the same SoC ID code. This means that there is no seperate machine
? ? ? ? ?directory (no arch/arm/mach-s3c2450) as the S3C2416 was first.

Thanks
Nobin

2010-06-02 15:58:51

by Randy Dunlap

[permalink] [raw]
Subject: Re: make ARM=arm menuconfig problem in mainline

On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:

> adding [email protected]
>
> Hi,
>
> The following entry creates problem in ARM System type menu. I am
> using a Fedora 12 system.

What kind of problem does it create?
It seems to work for me (on f11, not f12).
Does it have something to do with F12 specifically?


> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.

Describe the problem, please.

> config ARCH_S3C2410
> ? ? ? ?bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
> S3C2442, S3C2443, S3C2450"
> ? ? ? ?select GENERIC_GPIO
> ? ? ? ?select ARCH_HAS_CPUFREQ
> ? ? ? ?select HAVE_CLK
> ? ? ? ?select ARCH_USES_GETTIMEOFFSET
> ? ? ? ?help
> ? ? ? ? ?Samsung S3C2410X CPU based systems, such as the Simtec Electronics
> ? ? ? ? ?BAST (<http://www.simtec.co.uk/products/EB110ITX/>), the IPAQ 1940 or
> ? ? ? ? ?the Samsung SMDK2410 development board (and derivatives).
>
> ? ? ? ? ?Note, the S3C2416 and the S3C2450 are so close that they even share
> ? ? ? ? ?the same SoC ID code. This means that there is no seperate machine
> ? ? ? ? ?directory (no arch/arm/mach-s3c2450) as the S3C2416 was first.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

2010-06-02 16:09:00

by Nobin Mathew

[permalink] [raw]
Subject: Re: make ARM=arm menuconfig problem in mainline

Sorry if attachments are not allowed, when I go to select ARM system
type(OMAP, Davinci etc), I am not seeing any entries there in the pop
up window. When I remove bool "Samsung S3C2410, S3C2412, S3C2413,
S3C2416, S3C2440,
>> S3C2442, S3C2443, S3C2450" it is working fine. I feel it is something to do with length of that string.

Thanks
Nobin

On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <[email protected]> wrote:
> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
>
>> adding [email protected]
>>
>> Hi,
>>
>> The following entry creates problem in ARM System type menu. I am
>> using a Fedora 12 system.
>
> What kind of problem does it create?
> It seems to work for me (on f11, not f12).
> Does it have something to do with F12 specifically?
>
>
>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
>
> Describe the problem, please.
>
>> config ARCH_S3C2410
>> ? ? ? ?bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>> S3C2442, S3C2443, S3C2450"
>> ? ? ? ?select GENERIC_GPIO
>> ? ? ? ?select ARCH_HAS_CPUFREQ
>> ? ? ? ?select HAVE_CLK
>> ? ? ? ?select ARCH_USES_GETTIMEOFFSET
>> ? ? ? ?help
>> ? ? ? ? ?Samsung S3C2410X CPU based systems, such as the Simtec Electronics
>> ? ? ? ? ?BAST (<http://www.simtec.co.uk/products/EB110ITX/>), the IPAQ 1940 or
>> ? ? ? ? ?the Samsung SMDK2410 development board (and derivatives).
>>
>> ? ? ? ? ?Note, the S3C2416 and the S3C2450 are so close that they even share
>> ? ? ? ? ?the same SoC ID code. This means that there is no seperate machine
>> ? ? ? ? ?directory (no arch/arm/mach-s3c2450) as the S3C2416 was first.
>
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>


Attachments:
Screenshot.jpg (104.70 kB)

2010-06-02 16:10:26

by Nobin Mathew

[permalink] [raw]
Subject: Re: make ARM=arm menuconfig problem in mainline

when I go to select ARM system
type(OMAP, Davinci etc), I am not seeing any entries there in the pop
up window. When I remove bool "Samsung S3C2410, S3C2412, S3C2413,
S3C2416, S3C2440,
>> S3C2442, S3C2443, S3C2450" it is working fine. I feel it is something to do with length of that string.

Is it possible to attach screenshots in this list?

Thanks
Nobin

On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <[email protected]> wrote:
> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
>
>> adding [email protected]
>>
>> Hi,
>>
>> The following entry creates problem in ARM System type menu. I am
>> using a Fedora 12 system.
>
> What kind of problem does it create?
> It seems to work for me (on f11, not f12).
> Does it have something to do with F12 specifically?
>
>
>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
>
> Describe the problem, please.
>
>> config ARCH_S3C2410
>> ? ? ? ?bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>> S3C2442, S3C2443, S3C2450"
>> ? ? ? ?select GENERIC_GPIO
>> ? ? ? ?select ARCH_HAS_CPUFREQ
>> ? ? ? ?select HAVE_CLK
>> ? ? ? ?select ARCH_USES_GETTIMEOFFSET
>> ? ? ? ?help
>> ? ? ? ? ?Samsung S3C2410X CPU based systems, such as the Simtec Electronics
>> ? ? ? ? ?BAST (<http://www.simtec.co.uk/products/EB110ITX/>), the IPAQ 1940 or
>> ? ? ? ? ?the Samsung SMDK2410 development board (and derivatives).
>>
>> ? ? ? ? ?Note, the S3C2416 and the S3C2450 are so close that they even share
>> ? ? ? ? ?the same SoC ID code. This means that there is no seperate machine
>> ? ? ? ? ?directory (no arch/arm/mach-s3c2450) as the S3C2416 was first.
>
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>

2010-06-02 16:51:26

by Randy Dunlap

[permalink] [raw]
Subject: [TEMP PATCH] Re: make ARM=arm menuconfig problem in mainline

On 06/02/10 09:08, Nobin Mathew wrote:
>
> On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <[email protected]> wrote:
>> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
>>
>>> adding [email protected]
>>>
>>> Hi,
>>>
>>> The following entry creates problem in ARM System type menu. I am
>>> using a Fedora 12 system.
>>
>> What kind of problem does it create?
>> It seems to work for me (on f11, not f12).
>> Does it have something to do with F12 specifically?
>>
>>
>>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
>>
>> Describe the problem, please.

[please don't top-post]

> Sorry if attachments are not allowed, when I go to select ARM system
> type(OMAP, Davinci etc), I am not seeing any entries there in the pop
> up window. When I remove bool "Samsung S3C2410, S3C2412, S3C2413,
> S3C2416, S3C2440,
>>> S3C2442, S3C2443, S3C2450" it is working fine. I feel it is something to do with length of that string.
>
> Thanks
> Nobin


OK, I see that now. Well, it is some kind of problem.
Adding cc to linux-kbuild mailing list.


The patch below fixes the problem temporarily, but the bool string length does
seem to be a problem.

Thanks for your report.

--
From: Randy Dunlap <[email protected]>

The bool "long string" causes the choices not to be displayed,
so temporarily change it to a shorter string until a real fix
is found.

Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: Nobin Mathew <[email protected]>
Cc: Ben Dooks <[email protected]>
---
arch/arm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20100602.orig/arch/arm/Kconfig
+++ linux-next-20100602/arch/arm/Kconfig
@@ -629,7 +629,7 @@ config ARCH_SA1100
Support for StrongARM 11x0 based boards.

config ARCH_S3C2410
- bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450"
+ bool "Samsung S3C24xx"
select GENERIC_GPIO
select ARCH_HAS_CPUFREQ
select HAVE_CLK

2010-06-02 17:11:35

by Nobin Mathew

[permalink] [raw]
Subject: Re: [TEMP PATCH] Re: make ARM=arm menuconfig problem in mainline

On Wed, Jun 2, 2010 at 10:19 PM, Randy Dunlap <[email protected]> wrote:
> On 06/02/10 09:08, Nobin Mathew wrote:
>>
>> On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <[email protected]> wrote:
>>> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
>>>
>>>> adding [email protected]
>>>>
>>>> Hi,
>>>>
>>>> The following entry creates problem in ARM System type menu. I am
>>>> using a Fedora 12 system.
>>>
>>> What kind of problem does it create?
>>> It seems to work for me (on f11, not f12).
>>> Does it have something to do with F12 specifically?
>>>
>>>
>>>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>>>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
>>>
>>> Describe the problem, please.
>
> [please don't top-post]
Sorry I forgot. I rarely send mails to this list.
>
>> Sorry if attachments are not allowed, when I go to select ARM system
>> type(OMAP, Davinci etc), I am not seeing any entries there in the pop
>> up window. When I remove ?bool "Samsung S3C2410, S3C2412, S3C2413,
>> S3C2416, S3C2440,
>>>> S3C2442, S3C2443, S3C2450" ?it is working fine. I feel it is something to do with length of that string.
>>
>> Thanks
>> Nobin
>
>
> OK, I see that now. ?Well, it is some kind of problem.
> Adding cc to linux-kbuild mailing list.
>
>
> The patch below fixes the problem temporarily, but the bool string length does
> seem to be a problem.
>
> Thanks for your report.
>
> --
> From: Randy Dunlap <[email protected]>
>
> The bool "long string" causes the choices not to be displayed,
> so temporarily change it to a shorter string until a real fix
> is found.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: Nobin Mathew <[email protected]>
> Cc: Ben Dooks <[email protected]>
> ---
> ?arch/arm/Kconfig | ? ?2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20100602.orig/arch/arm/Kconfig
> +++ linux-next-20100602/arch/arm/Kconfig
> @@ -629,7 +629,7 @@ config ARCH_SA1100
> ? ? ? ? ?Support for StrongARM 11x0 based boards.
>
> ?config ARCH_S3C2410
> - ? ? ? bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450"
> + ? ? ? bool "Samsung S3C24xx"
> ? ? ? ?select GENERIC_GPIO
> ? ? ? ?select ARCH_HAS_CPUFREQ
> ? ? ? ?select HAVE_CLK
>

2010-06-03 00:25:42

by Ben Dooks

[permalink] [raw]
Subject: Re: [TEMP PATCH] Re: make ARM=arm menuconfig problem in mainline

On Wed, Jun 02, 2010 at 09:49:46AM -0700, Randy Dunlap wrote:
> On 06/02/10 09:08, Nobin Mathew wrote:
> >
> > On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <[email protected]> wrote:
> >> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
> >>
> >>> adding [email protected]
> >>>
> >>> Hi,
> >>>
> >>> The following entry creates problem in ARM System type menu. I am
> >>> using a Fedora 12 system.
> >>
> >> What kind of problem does it create?
> >> It seems to work for me (on f11, not f12).
> >> Does it have something to do with F12 specifically?
> >>
> >>
> >>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
> >>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
> >>
> >> Describe the problem, please.
>
> [please don't top-post]


I can think of several solutions, the first being to remove the S3C prefix
friom all these.

S3C24XX is not acceptable, there's S3C series that are either too old to
be bothered with, or don't fit under this architecture.

how about Samsung S3C: 2410,2412/3,2416,2440/2442,2443,2450


> > Sorry if attachments are not allowed, when I go to select ARM system
> > type(OMAP, Davinci etc), I am not seeing any entries there in the pop
> > up window. When I remove bool "Samsung S3C2410, S3C2412, S3C2413,
> > S3C2416, S3C2440,
> >>> S3C2442, S3C2443, S3C2450" it is working fine. I feel it is something to do with length of that string.
> >
> > Thanks
> > Nobin
>
>
> OK, I see that now. Well, it is some kind of problem.
> Adding cc to linux-kbuild mailing list.
>
>
> The patch below fixes the problem temporarily, but the bool string length does
> seem to be a problem.
>
> Thanks for your report.
>
> --
> From: Randy Dunlap <[email protected]>
>
> The bool "long string" causes the choices not to be displayed,
> so temporarily change it to a shorter string until a real fix
> is found.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: Nobin Mathew <[email protected]>
> Cc: Ben Dooks <[email protected]>
> ---
> arch/arm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20100602.orig/arch/arm/Kconfig
> +++ linux-next-20100602/arch/arm/Kconfig
> @@ -629,7 +629,7 @@ config ARCH_SA1100
> Support for StrongARM 11x0 based boards.
>
> config ARCH_S3C2410
> - bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450"
> + bool "Samsung S3C24xx"
> select GENERIC_GPIO
> select ARCH_HAS_CPUFREQ
> select HAVE_CLK

--
--
Ben

Q: What's a light-year?
A: One-third less calories than a regular year.

2010-06-03 01:14:20

by Randy Dunlap

[permalink] [raw]
Subject: Re: [TEMP PATCH v2] Re: make ARM=arm menuconfig problem in mainline

On 06/02/10 17:25, Ben Dooks wrote:
> On Wed, Jun 02, 2010 at 09:49:46AM -0700, Randy Dunlap wrote:
>> On 06/02/10 09:08, Nobin Mathew wrote:
>>>
>>> On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <[email protected]> wrote:
>>>> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
>>>>
>>>>> adding [email protected]
>>>>>
>>>>> Hi,
>>>>>
>>>>> The following entry creates problem in ARM System type menu. I am
>>>>> using a Fedora 12 system.
>>>>
>>>> What kind of problem does it create?
>>>> It seems to work for me (on f11, not f12).
>>>> Does it have something to do with F12 specifically?
>>>>
>>>>
>>>>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>>>>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
>>>>
>>>> Describe the problem, please.
>>
>> [please don't top-post]
>
>
> I can think of several solutions, the first being to remove the S3C prefix
> friom all these.
>
> S3C24XX is not acceptable, there's S3C series that are either too old to
> be bothered with, or don't fit under this architecture.

and not in the current kernel tree?
I did not find any others in the current tree....

> how about Samsung S3C: 2410,2412/3,2416,2440/2442,2443,2450

OK, that works.

For kbuild/kconfig people: run:
make ARCH=arm O=test menuconfig

and then select System Type & ARM system type. The kconfig "choice" menu at this
point looks empty. It seems to be just a text windowing/display problem.
Pressing the down/up arrow keys will display the choices, although not where they
should be displayed in the rectangle, and they can be selected there.


>>> Sorry if attachments are not allowed, when I go to select ARM system
>>> type(OMAP, Davinci etc), I am not seeing any entries there in the pop
>>> up window. When I remove bool "Samsung S3C2410, S3C2412, S3C2413,
>>> S3C2416, S3C2440,
>>>>> S3C2442, S3C2443, S3C2450" it is working fine. I feel it is something to do with length of that string.
>>>
>>> Thanks
>>> Nobin
>>
>>
>> OK, I see that now. Well, it is some kind of problem.
>> Adding cc to linux-kbuild mailing list.
>>
>>
>> The patch below fixes the problem temporarily, but the bool string length does
>> seem to be a problem.
>>
>> Thanks for your report.


---
From: Randy Dunlap <[email protected]>

"bool <long string>" causes kconfig choices not to be displayed
correctly, so temporarily change it to a shorter string until a real
fix is found.

Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: Nobin Mathew <[email protected]>
Cc: Ben Dooks <[email protected]>
---
arch/arm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20100602.orig/arch/arm/Kconfig
+++ linux-next-20100602/arch/arm/Kconfig
@@ -629,7 +629,7 @@ config ARCH_SA1100
Support for StrongARM 11x0 based boards.

config ARCH_S3C2410
- bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440, S3C2442, S3C2443, S3C2450"
+ bool "Samsung S3C: 2410,2412/3,2416,2440/2442,2443,2450"
select GENERIC_GPIO
select ARCH_HAS_CPUFREQ
select HAVE_CLK

2010-06-03 06:50:53

by Li Zefan

[permalink] [raw]
Subject: Re: [TEMP PATCH v2] Re: make ARM=arm menuconfig problem in mainline

Randy Dunlap wrote:
> On 06/02/10 17:25, Ben Dooks wrote:
>> On Wed, Jun 02, 2010 at 09:49:46AM -0700, Randy Dunlap wrote:
>>> On 06/02/10 09:08, Nobin Mathew wrote:
>>>> On Wed, Jun 2, 2010 at 9:27 PM, Randy Dunlap <[email protected]> wrote:
>>>>> On Wed, 2 Jun 2010 20:04:28 +0530 Nobin Mathew wrote:
>>>>>
>>>>>> adding [email protected]
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> The following entry creates problem in ARM System type menu. I am
>>>>>> using a Fedora 12 system.
>>>>> What kind of problem does it create?
>>>>> It seems to work for me (on f11, not f12).
>>>>> Does it have something to do with F12 specifically?
>>>>>
>>>>>
>>>>>> Length of bool "Samsung S3C2410, S3C2412, S3C2413, S3C2416, S3C2440,
>>>>>> S3C2442, S3C2443, S3C2450" is the problem. How can I fix it.
>>>>> Describe the problem, please.
>>> [please don't top-post]
>>
>> I can think of several solutions, the first being to remove the S3C prefix
>> friom all these.
>>
>> S3C24XX is not acceptable, there's S3C series that are either too old to
>> be bothered with, or don't fit under this architecture.
>
> and not in the current kernel tree?
> I did not find any others in the current tree....
>
>> how about Samsung S3C: 2410,2412/3,2416,2440/2442,2443,2450
>
> OK, that works.
>
> For kbuild/kconfig people: run:
> make ARCH=arm O=test menuconfig
>
> and then select System Type & ARM system type. The kconfig "choice" menu at this
> point looks empty. It seems to be just a text windowing/display problem.
> Pressing the down/up arrow keys will display the choices, although not where they
> should be displayed in the rectangle, and they can be selected there.
>

I've found out the cause of this bug, and I'll cook up a patch soon. ;)