2010-06-18 21:33:27

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH] mfd-core: properly handle platform_device_add_resources fail in mfd_add_device

On Mon, May 31, 2010 at 05:30:55PM +0800, Axel Lin wrote:
> platform_device_add_resources may fail, thus add error checking for it.
Thanks Axel, patch applied.

Cheers,
Samuel.


> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/mfd/mfd-core.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 7dd76bc..1823a57 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -70,7 +70,9 @@ static int mfd_add_device(struct device *parent, int id,
> goto fail_res;
> }
>
> - platform_device_add_resources(pdev, res, cell->num_resources);
> + ret = platform_device_add_resources(pdev, res, cell->num_resources);
> + if (ret)
> + goto fail_res;
>
> ret = platform_device_add(pdev);
> if (ret)
> --
> 1.5.4.3
>
>
>

--
Intel Open Source Technology Centre
http://oss.intel.com/