2010-07-03 16:04:06

by Kulikov Vasiliy

Subject: [PATCH 07/19] arch/x86/kernel: use for_each_pci_dev()

Use for_each_pci_dev() to simplify the code.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
arch/x86/kernel/k8.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/k8.c b/arch/x86/kernel/k8.c
index 0f7bc20..0ea4b35 100644
--- a/arch/x86/kernel/k8.c
+++ b/arch/x86/kernel/k8.c
@@ -27,11 +27,10 @@ EXPORT_SYMBOL(k8_northbridges);

static struct pci_dev *next_k8_northbridge(struct pci_dev *dev)
{
- do {
- dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
- if (!dev)
+ for_each_pci_dev(dev) {
+ if (pci_match_id(&k8_nb_ids[0], dev))
break;
- } while (!pci_match_id(&k8_nb_ids[0], dev));
+ }
return dev;
}

--
1.7.0.4

2010-07-04 07:49:12

by Borislav Petkov

Subject: Re: [PATCH 07/19] arch/x86/kernel: use for_each_pci_dev()

From: Kulikov Vasiliy <[email protected]>
Date: Sat, Jul 03, 2010 at 12:03:59PM -0400

> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>

Acked-by: Borislav Petkov <[email protected]>

> ---
> arch/x86/kernel/k8.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/k8.c b/arch/x86/kernel/k8.c
> index 0f7bc20..0ea4b35 100644
> --- a/arch/x86/kernel/k8.c
> +++ b/arch/x86/kernel/k8.c
> @@ -27,11 +27,10 @@ EXPORT_SYMBOL(k8_northbridges);
>
> static struct pci_dev *next_k8_northbridge(struct pci_dev *dev)
> {
> - do {
> - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
> - if (!dev)
> + for_each_pci_dev(dev) {
> + if (pci_match_id(&k8_nb_ids[0], dev))
> break;
> - } while (!pci_match_id(&k8_nb_ids[0], dev));
> + }
> return dev;
> }
>
> --
> 1.7.0.4
>
>

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632