2010-07-08 01:50:18

by Axel Lin

Subject: [PATCH] msi-wmi: make needlessly global symbols static

backlight is needlessly defined global.
This patch makes the symbol static.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/platform/x86/msi-wmi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
index d173600..42a5469 100644
--- a/drivers/platform/x86/msi-wmi.c
+++ b/drivers/platform/x86/msi-wmi.c
@@ -57,7 +57,7 @@ static struct key_entry msi_wmi_keymap[] = {
};
static ktime_t last_pressed[ARRAY_SIZE(msi_wmi_keymap) - 1];

-struct backlight_device *backlight;
+static struct backlight_device *backlight;

static int backlight_map[] = { 0x00, 0x33, 0x66, 0x99, 0xCC, 0xFF };

--
1.5.4.3

2010-07-08 08:44:10

by Anisse Astier

Subject: Re: [PATCH] msi-wmi: make needlessly global symbols static

Hi Axel,

On Thu, 08 Jul 2010 09:50:30 +0800, Axel Lin <[email protected]> wrote :

> backlight is needlessly defined global.
> This patch makes the symbol static.
>
> Signed-off-by: Axel Lin <[email protected]>
Acked-by: Anisse Astier <[email protected]>

Thanks,

Anisse

> ---
> drivers/platform/x86/msi-wmi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
> index d173600..42a5469 100644
> --- a/drivers/platform/x86/msi-wmi.c
> +++ b/drivers/platform/x86/msi-wmi.c
> @@ -57,7 +57,7 @@ static struct key_entry msi_wmi_keymap[] = {
> };
> static ktime_t last_pressed[ARRAY_SIZE(msi_wmi_keymap) - 1];
>
> -struct backlight_device *backlight;
> +static struct backlight_device *backlight;
>
> static int backlight_map[] = { 0x00, 0x33, 0x66, 0x99, 0xCC, 0xFF };
>