2010-07-14 18:02:22

by Kulikov Vasiliy

Subject: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk()

Use %p instead of %08x in printk().

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
arch/mips/kernel/smtc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/mips/kernel/smtc.c b/arch/mips/kernel/smtc.c
index a95dea5..cfeb2c1 100644
--- a/arch/mips/kernel/smtc.c
+++ b/arch/mips/kernel/smtc.c
@@ -975,8 +975,7 @@ void ipi_decode(struct smtc_ipi *pipi)
ipi_call_interrupt();
break;
default:
- printk("Impossible SMTC IPI Argument 0x%x\n",
- (int)arg_copy);
+ printk("Impossible SMTC IPI Argument %p\n", arg_copy);
break;
}
break;
--
1.7.0.4

2010-07-26 14:04:45

by Ralf Baechle

Subject: Re: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk()

On Wed, Jul 14, 2010 at 10:01:42PM +0400, Kulikov Vasiliy wrote:

> Use %p instead of %08x in printk().

Queued for 2.6.36, thanks!

Yes, %p is prefered here. But your log message doesn't mention that your
patch also does a functional change, it drops the 0x prefix of the printed
value ...

Ralf