I just got this from a patch I merged..
ERROR: need consistent spacing around '*' (ctx:WxV)
#121: FILE: arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c:113:
+static struct pcc_cpu __percpu *pcc_cpu_info;
^
which doesn't seem right.
Dave
On Wed, 2010-08-11 at 12:35 -0400, Dave Jones wrote:
> I just got this from a patch I merged..
>
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #121: FILE: arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c:113:
> +static struct pcc_cpu __percpu *pcc_cpu_info;
> ^
> which doesn't seem right.
Perhaps these need to be added to checkpatch.
Signed-off-by: Joe Perches <[email protected]>
---
scripts/checkpatch.pl | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2039acd..51ba019 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -150,6 +150,20 @@ our $Sparse = qr{
# We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
our $Attribute = qr{
const|
+ __percpu|
+ __nocast|
+ __safe|
+ __bitwise__|
+ __packed__|
+ __packed2__|
+ __naked|
+ __maybe_unused|
+ __always_unused|
+ __noreturn|
+ __used|
+ __cold|
+ __noclone|
+ __deprecated|
__read_mostly|
__kprobes|
__(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
On Wed, Aug 11, 2010 at 10:29:08AM -0700, Joe Perches wrote:
> On Wed, 2010-08-11 at 12:35 -0400, Dave Jones wrote:
> > I just got this from a patch I merged..
> >
> > ERROR: need consistent spacing around '*' (ctx:WxV)
> > #121: FILE: arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c:113:
> > +static struct pcc_cpu __percpu *pcc_cpu_info;
> > ^
> > which doesn't seem right.
>
> Perhaps these need to be added to checkpatch.
>
> Signed-off-by: Joe Perches <[email protected]>
This one looks sane to me, I've pulled this into my tree. The version
at the URL below should contain it for testing:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
-apw