2010-11-19 05:22:38

by Axel Lin

Subject: [PATCH] misc/isl29020: Remove incorrect kfree in isl29020_remove()

struct als_data *data is not used in this driver at all.

Also add a missing ">" character for MODULE_AUTHOR.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/misc/isl29020.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/isl29020.c b/drivers/misc/isl29020.c
index ca47e62..307aada 100644
--- a/drivers/misc/isl29020.c
+++ b/drivers/misc/isl29020.c
@@ -183,9 +183,7 @@ static int isl29020_probe(struct i2c_client *client,

static int isl29020_remove(struct i2c_client *client)
{
- struct als_data *data = i2c_get_clientdata(client);
sysfs_remove_group(&client->dev.kobj, &m_als_gr);
- kfree(data);
return 0;
}

@@ -245,6 +243,6 @@ static void __exit sensor_isl29020_exit(void)
module_init(sensor_isl29020_init);
module_exit(sensor_isl29020_exit);

-MODULE_AUTHOR("Kalhan Trisal <[email protected]");
+MODULE_AUTHOR("Kalhan Trisal <[email protected]>");
MODULE_DESCRIPTION("Intersil isl29020 ALS Driver");
MODULE_LICENSE("GPL v2");
--
1.7.2

2010-11-19 11:06:23

by Alan

Subject: Re: [PATCH] misc/isl29020: Remove incorrect kfree in isl29020_remove()

On Fri, 19 Nov 2010 13:27:17 +0800
Axel Lin <[email protected]> wrote:

> struct als_data *data is not used in this driver at all.
>
> Also add a missing ">" character for MODULE_AUTHOR.
>
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Alan Cox <[email protected]>

It stayed as NULL so the kfree was fine but it definitely wants removing