2011-02-04 17:49:13

by John Villalovos

Subject: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique

x86, apic: Make "broken BIOS!!" messages unique

There are five identical "broken BIOS!!" messages. This patch makes each
message unique so that it is easier to determine which message was actually
printed.

The 'inconceivable' messages are because it should not be possible to reach
those code paths.

Signed-off-by: John L. Villalovos <[email protected]>

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 697dc34..b0c40c3 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -841,7 +841,7 @@ static int MPBIOS_polarity(int idx)
}
case 2: /* reserved */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken BIOS: polarity!!\n");
polarity = 1;
break;
}
@@ -852,7 +852,7 @@ static int MPBIOS_polarity(int idx)
}
default: /* invalid */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken BIOS: inconceivable polarity!!\n");
polarity = 1;
break;
}
@@ -899,7 +899,7 @@ static int MPBIOS_trigger(int idx)
}
default:
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken BIOS: unknown bus type!!\n");
trigger = 1;
break;
}
@@ -913,7 +913,7 @@ static int MPBIOS_trigger(int idx)
}
case 2: /* reserved */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken BIOS: trigger!!\n");
trigger = 1;
break;
}
@@ -924,7 +924,7 @@ static int MPBIOS_trigger(int idx)
}
default: /* invalid */
{
- printk(KERN_WARNING "broken BIOS!!\n");
+ printk(KERN_WARNING "broken BIOS: inconceivable trigger!!\n");
trigger = 0;
break;
}

2011-02-04 18:58:45

by H. Peter Anvin

Subject: Re: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique

On 02/04/2011 09:48 AM, John Villalovos wrote:
> x86, apic: Make "broken BIOS!!" messages unique
>
> There are five identical "broken BIOS!!" messages. This patch makes each
> message unique so that it is easier to determine which message was actually
> printed.
>
> The 'inconceivable' messages are because it should not be possible to reach
> those code paths.

How about labelling these "MPBIOS" or so, too?

-hpa

2011-02-04 22:00:24

by Ingo Molnar

Subject: Re: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique

* H. Peter Anvin <[email protected]> wrote:

> On 02/04/2011 09:48 AM, John Villalovos wrote:
> > x86, apic: Make "broken BIOS!!" messages unique
> >
> > There are five identical "broken BIOS!!" messages. This patch makes each
> > message unique so that it is easier to determine which message was actually
> > printed.
> >
> > The 'inconceivable' messages are because it should not be possible to reach
> > those code paths.
>
> How about labelling these "MPBIOS" or so, too?

Yeah.

Also, the messages do not need to shout i suspect - the '!!' can be removed as well.

Thanks,

Ingo