2011-03-27 13:42:58

by Wanlong Gao

Subject: [PATCH] Fixed the format: lines over 80 characters .

From: Wanlong Gao <[email protected]>

Lines over 80 characters
FILE: janz-cmodio.c:273

Signed-off-by: Wanlong Gao <[email protected]>
---
drivers/mfd/janz-cmodio.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/janz-cmodio.c b/drivers/mfd/janz-cmodio.c
index 36a166b..fb29d23 100644
--- a/drivers/mfd/janz-cmodio.c
+++ b/drivers/mfd/janz-cmodio.c
@@ -270,8 +270,10 @@ static void __devexit cmodio_pci_remove(struct pci_dev *dev)

/* The list of devices that this module will support */
static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {
- { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
- { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
+ { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
+ PCI_VENDOR_ID_JANZ, 0x0101 },
+ { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
+ PCI_VENDOR_ID_JANZ, 0x0100 },
{ 0, }
};
MODULE_DEVICE_TABLE(pci, cmodio_pci_ids);
--
1.7.3

2011-03-27 13:54:07

by Alexey Dobriyan

Subject: Re: [PATCH] Fixed the format: lines over 80 characters .

On Sun, Mar 27, 2011 at 11:07:24AM +0800, [email protected] wrote:
> Lines over 80 characters

> static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
> + PCI_VENDOR_ID_JANZ, 0x0101 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
> + PCI_VENDOR_ID_JANZ, 0x0100 },

NAK, this is less readable.

2011-03-27 14:13:01

by Wanlong Gao

Subject: Re: Re: [PATCH] Fixed the format: lines over 80 characters .

I see, thanks .

------------------
wanlong.gao
2011-03-27

-------------------------------------------------------------
?????ˣ?Alexey Dobriyan
???????ڣ?2011-03-27 21:54:05
?ռ??ˣ?wanlong.gao
???ͣ?greg; harryxiyou; linux-kernel
???⣺Re: [PATCH] Fixed the format: lines over 80 characters .

On Sun, Mar 27, 2011 at 11:07:24AM +0800, [email protected] wrote:
> Lines over 80 characters

> static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
> + PCI_VENDOR_ID_JANZ, 0x0101 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
> + PCI_VENDOR_ID_JANZ, 0x0100 },

NAK, this is less readable.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?

2011-03-27 14:31:54

by Wanlong Gao

Subject: Re: Re: [PATCH] Fixed the format: lines over 80 characters .

But if you read the code in the 80 columns screen , isn't it less readable with the code over 80 characters ?

-------------------------------------------------------------
?????ˣ?Alexey Dobriyan
???????ڣ?2011-03-27 21:54:05
?ռ??ˣ?wanlong.gao
???ͣ?greg; harryxiyou; linux-kernel
???⣺Re: [PATCH] Fixed the format: lines over 80 characters .

On Sun, Mar 27, 2011 at 11:07:24AM +0800, [email protected] wrote:
> Lines over 80 characters

> static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
> + PCI_VENDOR_ID_JANZ, 0x0101 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
> + PCI_VENDOR_ID_JANZ, 0x0100 },

NAK, this is less readable.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?

2011-03-28 05:00:01

by jiaweiwei

Subject: Re: [PATCH] Fixed the format: lines over 80 characters .

On Sun, Mar 27, 2011 at 03:53:59PM +0300, Alexey Dobriyan wrote:
> On Sun, Mar 27, 2011 at 11:07:24AM +0800, [email protected] wrote:
> > Lines over 80 characters
> >
> > Signed-off-by: Wanlong Gao <[email protected]>
Acked-by: Harry Wei <[email protected]>
> NAK, this is less readable.
Hi Alexey,
I don't know how above patch decreases the readable for us.
Well, we should recognize it may be less readable after cleaning the
lines, which are over 80 characters. But this is well for me.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2011-03-28 17:30:56

by Steven Rostedt

Subject: Re: Re: [PATCH] Fixed the format: lines over 80 characters .

On Sun, Mar 27, 2011 at 10:31:46PM +0800, wanlong.gao wrote:
>
>
> But if you read the code in the 80 columns screen , isn't it less readable with the code over 80 characters ?

I too agree that it is less readable. Even if I read it in a 80 col
screen (which I seldom do), I could easily scroll to the right. This is
not code, its a table, and having each item on its own row makes it much
easier to read what field goes with what item.

-- Steve