The vmbus driver dependes on ACPI and PCI subsystems. Change
Kconfig to reflect this.
Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
---
drivers/staging/hv/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
index 76f0756..5e0c9f6 100644
--- a/drivers/staging/hv/Kconfig
+++ b/drivers/staging/hv/Kconfig
@@ -1,6 +1,6 @@
config HYPERV
tristate "Microsoft Hyper-V client drivers"
- depends on X86 && m
+ depends on X86 && ACPI && PCI && m
default n
help
Select this option to run Linux as a Hyper-V client operating
--
1.7.4.1
On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
>
> The vmbus driver dependes on ACPI and PCI subsystems. Change
> Kconfig to reflect this.
>
> Signed-off-by: K. Y. Srinivasan <[email protected]>
> Signed-off-by: Haiyang Zhang <[email protected]>
> ---
> drivers/staging/hv/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> index 76f0756..5e0c9f6 100644
> --- a/drivers/staging/hv/Kconfig
> +++ b/drivers/staging/hv/Kconfig
> @@ -1,6 +1,6 @@
> config HYPERV
> tristate "Microsoft Hyper-V client drivers"
> - depends on X86 && m
> + depends on X86 && ACPI && PCI && m
> default n
> help
> Select this option to run Linux as a Hyper-V client operating
ACPI itself depends on PCI. It also depends on IA64 || X86. Will the
vmbus driver work with IA64? If so the depends on could just be:
depends on ACPI && m
Also, default n is redudant since n is the default anyway.
Regards,
Hartley
> -----Original Message-----
> From: H Hartley Sweeten [mailto:[email protected]]
> Sent: Wednesday, May 04, 2011 2:44 PM
> To: KY Srinivasan; [email protected]; [email protected];
> [email protected]; [email protected]
> Cc: Haiyang Zhang
> Subject: RE: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv
> Kconfig
>
> On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> >
> > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > Kconfig to reflect this.
> >
> > Signed-off-by: K. Y. Srinivasan <[email protected]>
> > Signed-off-by: Haiyang Zhang <[email protected]>
> > ---
> > drivers/staging/hv/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > index 76f0756..5e0c9f6 100644
> > --- a/drivers/staging/hv/Kconfig
> > +++ b/drivers/staging/hv/Kconfig
> > @@ -1,6 +1,6 @@
> > config HYPERV
> > tristate "Microsoft Hyper-V client drivers"
> > - depends on X86 && m
> > + depends on X86 && ACPI && PCI && m
> > default n
> > help
> > Select this option to run Linux as a Hyper-V client operating
>
> ACPI itself depends on PCI. It also depends on IA64 || X86. Will the
> vmbus driver work with IA64? If so the depends on could just be:
>
> depends on ACPI && m
Good point; vmbus will not work on IA64 though. So, minimally we would want
X86 && ACPI. I will resend this with this change.
Regards,
K. Y
>
> Also, default n is redudant since n is the default anyway.
>
> Regards,
> Hartley
On Wed, May 04, 2011 at 11:51:45AM -0700, K. Y. Srinivasan wrote:
> config HYPERV
> tristate "Microsoft Hyper-V client drivers"
> - depends on X86 && m
> + depends on X86 && ACPI && PCI && m
I can't see anything preventing this driver from beeing built-in,
so the "depends on m" should probably go away.
On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> >
> > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > Kconfig to reflect this.
> >
> > Signed-off-by: K. Y. Srinivasan <[email protected]>
> > Signed-off-by: Haiyang Zhang <[email protected]>
> > ---
> > drivers/staging/hv/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > index 76f0756..5e0c9f6 100644
> > --- a/drivers/staging/hv/Kconfig
> > +++ b/drivers/staging/hv/Kconfig
> > @@ -1,6 +1,6 @@
> > config HYPERV
> > tristate "Microsoft Hyper-V client drivers"
> > - depends on X86 && m
> > + depends on X86 && ACPI && PCI && m
> > default n
> > help
> > Select this option to run Linux as a Hyper-V client operating
>
> ACPI itself depends on PCI.
Still? I thought that got removed a while ago.
> It also depends on IA64 || X86. Will the vmbus driver work with IA64?
No.
> If so the depends on could just be:
>
> depends on ACPI && m
No, see above for the IA64 reason.
> Also, default n is redudant since n is the default anyway.
True, but it doesn't hurt either :)
thanks,
greg k-h
On Wed, May 04, 2011 at 02:51:42PM -0400, Christoph Hellwig wrote:
> On Wed, May 04, 2011 at 11:51:45AM -0700, K. Y. Srinivasan wrote:
> > config HYPERV
> > tristate "Microsoft Hyper-V client drivers"
> > - depends on X86 && m
> > + depends on X86 && ACPI && PCI && m
>
> I can't see anything preventing this driver from beeing built-in,
> so the "depends on m" should probably go away.
Originally there were some problems with some bad global symbols.
Hopefully those should all be resolved now, but it can't hurt to review
the code to verify this first.
thanks,
greg k-h
On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
> On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > >
> > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > Kconfig to reflect this.
> > >
> > > Signed-off-by: K. Y. Srinivasan <[email protected]>
> > > Signed-off-by: Haiyang Zhang <[email protected]>
> > > ---
> > > drivers/staging/hv/Kconfig | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > index 76f0756..5e0c9f6 100644
> > > --- a/drivers/staging/hv/Kconfig
> > > +++ b/drivers/staging/hv/Kconfig
> > > @@ -1,6 +1,6 @@
> > > config HYPERV
> > > tristate "Microsoft Hyper-V client drivers"
> > > - depends on X86 && m
> > > + depends on X86 && ACPI && PCI && m
> > > default n
> > > help
> > > Select this option to run Linux as a Hyper-V client operating
> >
> > ACPI itself depends on PCI.
>
> Still? I thought that got removed a while ago.
Still. Len has written in the past that technically there is no such
dependency, but in reality there is, for now at least. IIRC.
> > It also depends on IA64 || X86. Will the vmbus driver work with IA64?
>
> No.
>
> > If so the depends on could just be:
> >
> > depends on ACPI && m
>
> No, see above for the IA64 reason.
>
> > Also, default n is redudant since n is the default anyway.
>
> True, but it doesn't hurt either :)
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote:
> On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
>
> > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > > >
> > > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > > Kconfig to reflect this.
> > > >
> > > > Signed-off-by: K. Y. Srinivasan <[email protected]>
> > > > Signed-off-by: Haiyang Zhang <[email protected]>
> > > > ---
> > > > drivers/staging/hv/Kconfig | 2 +-
> > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > > index 76f0756..5e0c9f6 100644
> > > > --- a/drivers/staging/hv/Kconfig
> > > > +++ b/drivers/staging/hv/Kconfig
> > > > @@ -1,6 +1,6 @@
> > > > config HYPERV
> > > > tristate "Microsoft Hyper-V client drivers"
> > > > - depends on X86 && m
> > > > + depends on X86 && ACPI && PCI && m
> > > > default n
> > > > help
> > > > Select this option to run Linux as a Hyper-V client operating
> > >
> > > ACPI itself depends on PCI.
> >
> > Still? I thought that got removed a while ago.
>
> Still. Len has written in the past that technically there is no such
> dependency, but in reality there is, for now at least. IIRC.
Ok, but then we should still say we depend on PCI to handle if/when ACPI
removes that dependancy in the future. It doesn't hurt here at all.
thanks,
greg k-h
> -----Original Message-----
> From: [email protected] [mailto:devel-
> [email protected]] On Behalf Of Greg KH
> Sent: Wednesday, May 04, 2011 3:40 PM
> To: Randy Dunlap
> Cc: [email protected]; [email protected]; H Hartley
> Sweeten; Haiyang Zhang; [email protected]
> Subject: Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv
> Kconfig
>
> On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote:
> > On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
> >
> > > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > > > >
> > > > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > > > Kconfig to reflect this.
> > > > >
> > > > > Signed-off-by: K. Y. Srinivasan <[email protected]>
> > > > > Signed-off-by: Haiyang Zhang <[email protected]>
> > > > > ---
> > > > > drivers/staging/hv/Kconfig | 2 +-
> > > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > > >
> > > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > > > index 76f0756..5e0c9f6 100644
> > > > > --- a/drivers/staging/hv/Kconfig
> > > > > +++ b/drivers/staging/hv/Kconfig
> > > > > @@ -1,6 +1,6 @@
> > > > > config HYPERV
> > > > > tristate "Microsoft Hyper-V client drivers"
> > > > > - depends on X86 && m
> > > > > + depends on X86 && ACPI && PCI && m
> > > > > default n
> > > > > help
> > > > > Select this option to run Linux as a Hyper-V client operating
> > > >
> > > > ACPI itself depends on PCI.
> > >
> > > Still? I thought that got removed a while ago.
> >
> > Still. Len has written in the past that technically there is no such
> > dependency, but in reality there is, for now at least. IIRC.
>
> Ok, but then we should still say we depend on PCI to handle if/when ACPI
> removes that dependancy in the future. It doesn't hurt here at all.
Greg,
I have sent you both versions of this patch; one with explicit dependency on PCI and
one with implicit dependency on PCI; you decide.
Regards,
K. Y
On Wed, 4 May 2011 12:39:54 -0700 Greg KH wrote:
> On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote:
> > On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
> >
> > > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > > > >
> > > > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > > > Kconfig to reflect this.
> > > > >
> > > > > Signed-off-by: K. Y. Srinivasan <[email protected]>
> > > > > Signed-off-by: Haiyang Zhang <[email protected]>
> > > > > ---
> > > > > drivers/staging/hv/Kconfig | 2 +-
> > > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > > >
> > > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > > > index 76f0756..5e0c9f6 100644
> > > > > --- a/drivers/staging/hv/Kconfig
> > > > > +++ b/drivers/staging/hv/Kconfig
> > > > > @@ -1,6 +1,6 @@
> > > > > config HYPERV
> > > > > tristate "Microsoft Hyper-V client drivers"
> > > > > - depends on X86 && m
> > > > > + depends on X86 && ACPI && PCI && m
> > > > > default n
> > > > > help
> > > > > Select this option to run Linux as a Hyper-V client operating
> > > >
> > > > ACPI itself depends on PCI.
> > >
> > > Still? I thought that got removed a while ago.
> >
> > Still. Len has written in the past that technically there is no such
> > dependency, but in reality there is, for now at least. IIRC.
>
> Ok, but then we should still say we depend on PCI to handle if/when ACPI
> removes that dependancy in the future. It doesn't hurt here at all.
Yes, I prefer that also.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Wed, May 04, 2011 at 07:54:09PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: [email protected] [mailto:devel-
> > [email protected]] On Behalf Of Greg KH
> > Sent: Wednesday, May 04, 2011 3:40 PM
> > To: Randy Dunlap
> > Cc: [email protected]; [email protected]; H Hartley
> > Sweeten; Haiyang Zhang; [email protected]
> > Subject: Re: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv
> > Kconfig
> >
> > On Wed, May 04, 2011 at 12:33:02PM -0700, Randy Dunlap wrote:
> > > On Wed, 4 May 2011 11:53:38 -0700 Greg KH wrote:
> > >
> > > > On Wed, May 04, 2011 at 01:44:27PM -0500, H Hartley Sweeten wrote:
> > > > > On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> > > > > >
> > > > > > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > > > > > Kconfig to reflect this.
> > > > > >
> > > > > > Signed-off-by: K. Y. Srinivasan <[email protected]>
> > > > > > Signed-off-by: Haiyang Zhang <[email protected]>
> > > > > > ---
> > > > > > drivers/staging/hv/Kconfig | 2 +-
> > > > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > > > > > index 76f0756..5e0c9f6 100644
> > > > > > --- a/drivers/staging/hv/Kconfig
> > > > > > +++ b/drivers/staging/hv/Kconfig
> > > > > > @@ -1,6 +1,6 @@
> > > > > > config HYPERV
> > > > > > tristate "Microsoft Hyper-V client drivers"
> > > > > > - depends on X86 && m
> > > > > > + depends on X86 && ACPI && PCI && m
> > > > > > default n
> > > > > > help
> > > > > > Select this option to run Linux as a Hyper-V client operating
> > > > >
> > > > > ACPI itself depends on PCI.
> > > >
> > > > Still? I thought that got removed a while ago.
> > >
> > > Still. Len has written in the past that technically there is no such
> > > dependency, but in reality there is, for now at least. IIRC.
> >
> > Ok, but then we should still say we depend on PCI to handle if/when ACPI
> > removes that dependancy in the future. It doesn't hurt here at all.
>
> Greg,
> I have sent you both versions of this patch; one with explicit dependency on PCI and
> one with implicit dependency on PCI; you decide.
Thanks, I'll pick one :)