2012-02-06 05:22:44

by Michael Neuling

Subject: Re: [PATCH v3 21/25] irqdomain/powerpc: Replace custom xlate functions with library functions

> static const struct irq_domain_ops pmac_pic_host_ops = {
> .match = pmac_pic_host_match,
> .map = pmac_pic_host_map,
> - .xlate = pmac_pic_host_xlate,
> + .xlate = irq_domain_xlate_onecell;
> };
>

This causes a compile fail (in next-20120206):
arch/powerpc/platforms/powermac/pic.c:294: error: expected '}' before ';' token
Trivial fix below:



irqdomain/powerpc: Fix compile error in powermac/pic.c

Error introduced in:
commit 72d6b477675374eafd206720d6c9146520df18ce
Author: Grant Likely <[email protected]>
irqdomain/powerpc: Replace custom xlate functions with library functions

Signed-off-by: Michael Neuling <[email protected]>

diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c
index 3af29d1..92afc38 100644
--- a/arch/powerpc/platforms/powermac/pic.c
+++ b/arch/powerpc/platforms/powermac/pic.c
@@ -291,7 +291,7 @@ static int pmac_pic_host_map(struct irq_domain *h, unsigned int virq,
static const struct irq_domain_ops pmac_pic_host_ops = {
.match = pmac_pic_host_match,
.map = pmac_pic_host_map,
- .xlate = irq_domain_xlate_onecell;
+ .xlate = irq_domain_xlate_onecell,
};

static void __init pmac_pic_probe_oldstyle(void)

2012-02-06 06:00:10

by Grant Likely

Subject: Re: [PATCH v3 21/25] irqdomain/powerpc: Replace custom xlate functions with library functions

On Mon, Feb 06, 2012 at 04:22:41PM +1100, Michael Neuling wrote:
> > static const struct irq_domain_ops pmac_pic_host_ops = {
> > .match = pmac_pic_host_match,
> > .map = pmac_pic_host_map,
> > - .xlate = pmac_pic_host_xlate,
> > + .xlate = irq_domain_xlate_onecell;
> > };
> >
>
> This causes a compile fail (in next-20120206):
> arch/powerpc/platforms/powermac/pic.c:294: error: expected '}' before ';' token
> Trivial fix below:

fixed, thanks.

g.

>
>
>
> irqdomain/powerpc: Fix compile error in powermac/pic.c
>
> Error introduced in:
> commit 72d6b477675374eafd206720d6c9146520df18ce
> Author: Grant Likely <[email protected]>
> irqdomain/powerpc: Replace custom xlate functions with library functions
>
> Signed-off-by: Michael Neuling <[email protected]>
>
> diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c
> index 3af29d1..92afc38 100644
> --- a/arch/powerpc/platforms/powermac/pic.c
> +++ b/arch/powerpc/platforms/powermac/pic.c
> @@ -291,7 +291,7 @@ static int pmac_pic_host_map(struct irq_domain *h, unsigned int virq,
> static const struct irq_domain_ops pmac_pic_host_ops = {
> .match = pmac_pic_host_match,
> .map = pmac_pic_host_map,
> - .xlate = irq_domain_xlate_onecell;
> + .xlate = irq_domain_xlate_onecell,
> };
>
> static void __init pmac_pic_probe_oldstyle(void)