2012-05-03 13:57:28

by Marcus Folkesson

[permalink] [raw]
Subject: [PATCH] i2c: davinci: Free requested IRQ in remove

The freed IRQ is not necessary the one requested in probe.
Even if it was, with two or more i2c-controllers it will fails anyway.

Signed-off-by: Marcus Folkesson <[email protected]>
---
drivers/i2c/busses/i2c-davinci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index a76d85f..79b4bcb 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -755,7 +755,7 @@ static int davinci_i2c_remove(struct platform_device *pdev)
dev->clk = NULL;

davinci_i2c_write_reg(dev, DAVINCI_I2C_MDR_REG, 0);
- free_irq(IRQ_I2C, dev);
+ free_irq(dev->irq, dev);
iounmap(dev->base);
kfree(dev);

--
1.7.5.4


2012-05-12 12:36:30

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: davinci: Free requested IRQ in remove

On Thu, May 03, 2012 at 03:56:36PM +0200, Marcus Folkesson wrote:
> The freed IRQ is not necessary the one requested in probe.
> Even if it was, with two or more i2c-controllers it will fails anyway.
>
> Signed-off-by: Marcus Folkesson <[email protected]>

Applied to current, thanks!

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |


Attachments:
(No filename) (450.00 B)
signature.asc (198.00 B)
Digital signature
Download all attachments