2012-05-18 21:48:58

by Jeffrin Jose

Subject: [PATCH 1/1]net:ethernet:fixed a coding style issue relating space.

Fixed a coding style issue relating to space found
by checkpatch.pl tool in net/ethernet/eth.c

Signed-off-by: Jeffrin Jose <[email protected]>
---
net/ethernet/eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index 36e5880..c847aa6 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
* seems to set IFF_PROMISC.
*/

- else if (1 /*dev->flags&IFF_PROMISC */ ) {
+ else if (1 /*dev->flags&IFF_PROMISC */) {
if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
dev->dev_addr)))
skb->pkt_type = PACKET_OTHERHOST;
--
1.7.10

2012-05-18 21:56:21

by Stephen Hemminger

Subject: Re: [PATCH 1/1]net:ethernet:fixed a coding style issue relating space.

On Sat, 19 May 2012 03:15:37 +0530
Jeffrin Jose <[email protected]> wrote:

> Fixed a coding style issue relating to space found
> by checkpatch.pl tool in net/ethernet/eth.c
>
> Signed-off-by: Jeffrin Jose <[email protected]>
> ---
> net/ethernet/eth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
> index 36e5880..c847aa6 100644
> --- a/net/ethernet/eth.c
> +++ b/net/ethernet/eth.c
> @@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
> * seems to set IFF_PROMISC.
> */
>
> - else if (1 /*dev->flags&IFF_PROMISC */ ) {
> + else if (1 /*dev->flags&IFF_PROMISC */) {
> if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
> dev->dev_addr)))
> skb->pkt_type = PACKET_OTHERHOST;

Rather than put lips on a pig, why not remove the bogus if?

2012-05-19 18:36:17

by David Miller

Subject: Re: [PATCH 1/1]net:ethernet:fixed a coding style issue relating space.

From: Jeffrin Jose <[email protected]>
Date: Sat, 19 May 2012 18:02:12 +0800 (SGT)

>>> Rather than put lips on a pig, why not remove the bogus if?
> is there anything i should work on this patch or should i move on

He's telling you to remove the code rather then try to fix
it's coding style.