2012-08-05 21:00:26

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH] drm/i915: Fix mem leak in intel_sdvo_write_cmd()

On Tue, Jul 31, 2012 at 10:31:15PM +0200, Jesper Juhl wrote:
> If the allocation of 'buf' succeeds but the allocation of 'msgs' fails
> we'll return false and leak 'buf' when it goes out of scope.
>
> Signed-off-by: Jesper Juhl <[email protected]>

I've already merged a similar patch from Alan Cox for -fixes, should land
in 3.6 soonish.
-Daniel
--
Daniel Vetter
Mail: [email protected]
Mobile: +41 (0)79 365 57 48


2012-08-05 21:19:36

by Jesper Juhl

[permalink] [raw]
Subject: Re: [PATCH] drm/i915: Fix mem leak in intel_sdvo_write_cmd()

On Sun, 5 Aug 2012, Daniel Vetter wrote:

> On Tue, Jul 31, 2012 at 10:31:15PM +0200, Jesper Juhl wrote:
> > If the allocation of 'buf' succeeds but the allocation of 'msgs' fails
> > we'll return false and leak 'buf' when it goes out of scope.
> >
> > Signed-off-by: Jesper Juhl <[email protected]>
>
> I've already merged a similar patch from Alan Cox for -fixes, should land
> in 3.6 soonish.

Perfect.

--
Jesper Juhl <[email protected]> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.