2012-08-20 19:50:46

by Ondrej Zary

Subject: [PATCH] snd-als100: fix suspend/resume

snd_card_als100_probe() does not set pcm field in struct snd_sb.
As a result, PCM is not suspended and applications don't know that they need
to resume the playback.

Tested with Labway A381-F20 card (ALS120).

Signed-off-by: Ondrej Zary <[email protected]>

--- a/sound/isa/als100.c
+++ b/sound/isa/als100.c
@@ -233,7 +233,7 @@ static int __devinit snd_card_als100_probe(int dev,
irq[dev], dma8[dev], dma16[dev]);
}

- if ((error = snd_sb16dsp_pcm(chip, 0, NULL)) < 0) {
+ if ((error = snd_sb16dsp_pcm(chip, 0, &chip->pcm)) < 0) {
snd_card_free(card);
return error;
}




--
Ondrej Zary

2012-08-21 08:00:49

by Takashi Iwai

Subject: Re: [alsa-devel] [PATCH] snd-als100: fix suspend/resume

At Mon, 20 Aug 2012 21:50:13 +0200,
Ondrej Zary wrote:
>
> snd_card_als100_probe() does not set pcm field in struct snd_sb.
> As a result, PCM is not suspended and applications don't know that they need
> to resume the playback.
>
> Tested with Labway A381-F20 card (ALS120).
>
> Signed-off-by: Ondrej Zary <[email protected]>

Applied now. Thanks.


Takashi

>
> --- a/sound/isa/als100.c
> +++ b/sound/isa/als100.c
> @@ -233,7 +233,7 @@ static int __devinit snd_card_als100_probe(int dev,
> irq[dev], dma8[dev], dma16[dev]);
> }
>
> - if ((error = snd_sb16dsp_pcm(chip, 0, NULL)) < 0) {
> + if ((error = snd_sb16dsp_pcm(chip, 0, &chip->pcm)) < 0) {
> snd_card_free(card);
> return error;
> }
>
>
>
>
> --
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> [email protected]
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>