2013-06-21 01:30:52

by Alasdair G Kergon

[permalink] [raw]
Subject: Re: [dm-devel] [PATCH] dm: verity: Add support for emitting uevents on dm-verity errors.

On Thu, Jun 20, 2013 at 06:12:07PM -0700, Geremy Condra wrote:
> Assuming nobody currently using DM_UEVENT minds it doesn't cause any
> problems for me. Any current users object?

DM_UEVENT toggles uevents on or off across the whole of device-mapper.

If there is no particular need for verity *not* to generate uevents
while other parts of device-mapper *are* generating them, then we can
make do with just the one Kconfig parameter. (Userspace is still free
to ignore particular events.)

So let's drop the second config parameter.

Alasdair


2013-06-21 03:00:15

by Geremy Condra

[permalink] [raw]
Subject: Re: [dm-devel] [PATCH] dm: verity: Add support for emitting uevents on dm-verity errors.

On Thu, Jun 20, 2013 at 6:30 PM, Alasdair G Kergon <[email protected]> wrote:
> On Thu, Jun 20, 2013 at 06:12:07PM -0700, Geremy Condra wrote:
>> Assuming nobody currently using DM_UEVENT minds it doesn't cause any
>> problems for me. Any current users object?
>
> DM_UEVENT toggles uevents on or off across the whole of device-mapper.
>
> If there is no particular need for verity *not* to generate uevents
> while other parts of device-mapper *are* generating them, then we can
> make do with just the one Kconfig parameter. (Userspace is still free
> to ignore particular events.)
>
> So let's drop the second config parameter.

SGTM, next patch coming up- thanks for taking the time to review!

Geremy Condra

>
> Alasdair
>