2013-09-02 07:15:31

by Jon Arne Jørgensen

[permalink] [raw]
Subject: Re: [RFC,v3] Add a driver for the Somagic smi2021 chip

On Mon, Sep 02, 2013 at 03:50:14AM +0800, Wang Shilong wrote:
Hi,
> Hello, Using checkpatch.pl, i get the following warnings(errors):
> WARNING: Avoid CamelCase: <udev->descriptor.idProduct>
> #1766: FILE: drivers/media/usb/smi2021/smi2021_main.c:790:
> + if (udev->descriptor.idProduct == BOOTLOADER_ID)
>
> total: 0 errors, 1 warnings, 2110 lines checked
>
> patch has style problems, please review.
>
That problem lies within the usb-subsystem.

When I ran checkpatch.pl on the patch before submitting this didn't show up.
Are you using an old version of checkpatch.pl?

> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> Thanks, Wang
>
> Notice: this is an automatically generated by shell script
> Any problems please contact: [email protected]