Hi,
The ChangeLog from [1] says:
Commit 229455bc02b87f7128f190c4491b4ceffff38648 accidentally changed
the separator between sed `s' command and its parameters from ':' to
'/'.
Revert this change.
Reported-and-tested-by: Linus Walleij <[email protected]>
Signed-off-by: Clement Chauplannaz <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
*** Bad commit reference: 229455bc02b87f7128f190c4491b4ceffff38648 ***
(Linus-tree)
To quote [2] and see its EXAMPLE:
"If you want to refer to a specific commit, don't just refer to the
SHA-1 ID of the commit. Please also include the oneline summary of
the commit, to make it easier for reviewers to know what it is about.
Example:
Commit e21d2170f36602ae2708 ("video: remove unnecessary
platform_set_drvdata()") removed the unnecessary
platform_set_drvdata(), but left the variable "dev" unused,
delete it."
That's why the commit-id without the subject-line is no good help.
It does not help anyone when you reference a local GIT or linux-kbuild
GIT related commit-id.
So, can you point me/us to the correct commit with subject, please?!
Is this patch even "CC: stable"?
Thanks.
Regards,
- Sedat -
[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=86eb781889ec31f6421b86ab252ea609d456322d
[2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n112
2013/9/14 Sedat Dilek <[email protected]>:
> Hi,
>
> The ChangeLog from [1] says:
>
> Commit 229455bc02b87f7128f190c4491b4ceffff38648 accidentally changed
> the separator between sed `s' command and its parameters from ':' to
> '/'.
> Revert this change.
>
> Reported-and-tested-by: Linus Walleij <[email protected]>
> Signed-off-by: Clement Chauplannaz <[email protected]>
> Signed-off-by: Michal Marek <[email protected]>
>
> *** Bad commit reference: 229455bc02b87f7128f190c4491b4ceffff38648 ***
> (Linus-tree)
>
> To quote [2] and see its EXAMPLE:
>
> "If you want to refer to a specific commit, don't just refer to the
> SHA-1 ID of the commit. Please also include the oneline summary of
> the commit, to make it easier for reviewers to know what it is about.
>
> Example:
>
> Commit e21d2170f36602ae2708 ("video: remove unnecessary
> platform_set_drvdata()") removed the unnecessary
> platform_set_drvdata(), but left the variable "dev" unused,
> delete it."
>
> That's why the commit-id without the subject-line is no good help.
> It does not help anyone when you reference a local GIT or linux-kbuild
> GIT related commit-id.
>
> So, can you point me/us to the correct commit with subject, please?!
> Is this patch even "CC: stable"?
>
> Thanks.
>
> Regards,
> - Sedat -
>
>
> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=86eb781889ec31f6421b86ab252ea609d456322d
> [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n112
Hi Sedat,
My apologies for that mistake. The initial commit, as present in Linus tree, is:
83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce - scripts/config: use sed's
POSIX interface
Thus, the commit message for this patch should read:
scripts/config: fix variable substitution command
Commit 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce ("scripts/config: use sed's
POSIX interface") accidentally changed the separator between sed `s' command
and its parameters from ':' to '/'.
Revert this change.
Reported-and-tested-by: Linus Walleij <[email protected]>
Signed-off-by: Clement Chauplannaz <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
Regards,
Clement
On Sat, Sep 14, 2013 at 4:21 PM, Clément Chauplannaz <[email protected]> wrote:
> 2013/9/14 Sedat Dilek <[email protected]>:
>> Hi,
>>
>> The ChangeLog from [1] says:
>>
>> Commit 229455bc02b87f7128f190c4491b4ceffff38648 accidentally changed
>> the separator between sed `s' command and its parameters from ':' to
>> '/'.
>> Revert this change.
>>
>> Reported-and-tested-by: Linus Walleij <[email protected]>
>> Signed-off-by: Clement Chauplannaz <[email protected]>
>> Signed-off-by: Michal Marek <[email protected]>
>>
>> *** Bad commit reference: 229455bc02b87f7128f190c4491b4ceffff38648 ***
>> (Linus-tree)
>>
>> To quote [2] and see its EXAMPLE:
>>
>> "If you want to refer to a specific commit, don't just refer to the
>> SHA-1 ID of the commit. Please also include the oneline summary of
>> the commit, to make it easier for reviewers to know what it is about.
>>
>> Example:
>>
>> Commit e21d2170f36602ae2708 ("video: remove unnecessary
>> platform_set_drvdata()") removed the unnecessary
>> platform_set_drvdata(), but left the variable "dev" unused,
>> delete it."
>>
>> That's why the commit-id without the subject-line is no good help.
>> It does not help anyone when you reference a local GIT or linux-kbuild
>> GIT related commit-id.
>>
>> So, can you point me/us to the correct commit with subject, please?!
>> Is this patch even "CC: stable"?
>>
>> Thanks.
>>
>> Regards,
>> - Sedat -
>>
>>
>> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=86eb781889ec31f6421b86ab252ea609d456322d
>> [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n112
>
>
> Hi Sedat,
>
> My apologies for that mistake. The initial commit, as present in Linus tree, is:
> 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce - scripts/config: use sed's
> POSIX interface
>
> Thus, the commit message for this patch should read:
> scripts/config: fix variable substitution command
>
> Commit 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce ("scripts/config: use sed's
> POSIX interface") accidentally changed the separator between sed `s' command
> and its parameters from ':' to '/'.
>
> Revert this change.
>
> Reported-and-tested-by: Linus Walleij <[email protected]>
> Signed-off-by: Clement Chauplannaz <[email protected]>
> Signed-off-by: Michal Marek <[email protected]>
>
What means "pending" [1]?
Pending in sense of "we are working on it" or in the sense of
"exists-but-not-published".
I did not found a hint on the offline linux-kbuild ML.
BTW, the GIT repo of Yann is not browsable (which is sh*t for checking
commits quickl, I don't want to be forced to checkout).
- Sedat -
[1] http://marc.info/?l=linux-kbuild&m=137907590807755&w=2
[2] https://www.gitorious.org/linux-kconfig/linux-kconfig/
Sedat, All,
On 2013-09-14 14:21 +0200, Sedat Dilek spake thusly:
> The ChangeLog from [1] says:
>
> Commit 229455bc02b87f7128f190c4491b4ceffff38648 accidentally changed
> the separator between sed `s' command and its parameters from ':' to
> '/'.
> Revert this change.
[--SNIP--]
> Is this patch even "CC: stable"?
It was not in any previous released version, since it went in Linus'
tree for 3.12. As such, it does not make sense to Cc: stable.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
Sedat, All,
On 2013-09-14 16:43 +0200, Sedat Dilek spake thusly:
> On Sat, Sep 14, 2013 at 4:21 PM, Clément Chauplannaz <[email protected]> wrote:
> > 2013/9/14 Sedat Dilek <[email protected]>:
[--SNIP--]
> >> So, can you point me/us to the correct commit with subject, please?!
> >
> > My apologies for that mistake. The initial commit, as present in Linus tree, is:
> > 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce - scripts/config: use sed's
> > POSIX interface
> >
> > Thus, the commit message for this patch should read:
> > scripts/config: fix variable substitution command
> >
> > Commit 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce ("scripts/config: use sed's
> > POSIX interface") accidentally changed the separator between sed `s' command
> > and its parameters from ':' to '/'.
> >
> > Revert this change.
> >
> > Reported-and-tested-by: Linus Walleij <[email protected]>
> > Signed-off-by: Clement Chauplannaz <[email protected]>
> > Signed-off-by: Michal Marek <[email protected]>
> >
>
> What means "pending" [1]?
The current script had a latent bug that would trigger when the user want
to set a string that contains a colon ':'.
This behaviour was changed by Clément, and the bug was then about strings
with a '/' instead. This was a regression for some users.
The behaviour was then reverted to break on strings containing ':'.
What is pending is a final fix that will fix both cases.
> Pending in sense of "we are working on it" or in the sense of
> "exists-but-not-published".
The final fix is trivial and identified, so I guess that Clément has yet
had time to send the patch.
> I did not found a hint on the offline linux-kbuild ML.
That would be Michal's suggestion there:
http://marc.info/?l=linux-kbuild&m=137907001305533&w=2
> BTW, the GIT repo of Yann is not browsable (which is sh*t for checking
> commits quickl, I don't want to be forced to checkout).
Yes, I know about that one. I've already notified the gitorious guys
about the issue, they supposedly fixed it, but it is broken again.
I will re-open my ticket in a moment.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
On Sun, Sep 15, 2013 at 1:39 AM, Yann E. MORIN <[email protected]> wrote:
> Sedat, All,
>
> On 2013-09-14 16:43 +0200, Sedat Dilek spake thusly:
>> On Sat, Sep 14, 2013 at 4:21 PM, Clément Chauplannaz <[email protected]> wrote:
>> > 2013/9/14 Sedat Dilek <[email protected]>:
> [--SNIP--]
>> >> So, can you point me/us to the correct commit with subject, please?!
>> >
>> > My apologies for that mistake. The initial commit, as present in Linus tree, is:
>> > 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce - scripts/config: use sed's
>> > POSIX interface
>> >
>> > Thus, the commit message for this patch should read:
>> > scripts/config: fix variable substitution command
>> >
>> > Commit 83e8b90e1d2cc5ff5d2443f2486c2d786a4997ce ("scripts/config: use sed's
>> > POSIX interface") accidentally changed the separator between sed `s' command
>> > and its parameters from ':' to '/'.
>> >
>> > Revert this change.
>> >
>> > Reported-and-tested-by: Linus Walleij <[email protected]>
>> > Signed-off-by: Clement Chauplannaz <[email protected]>
>> > Signed-off-by: Michal Marek <[email protected]>
>> >
>>
>> What means "pending" [1]?
>
> The current script had a latent bug that would trigger when the user want
> to set a string that contains a colon ':'.
>
> This behaviour was changed by Clément, and the bug was then about strings
> with a '/' instead. This was a regression for some users.
>
> The behaviour was then reverted to break on strings containing ':'.
>
> What is pending is a final fix that will fix both cases.
>
>> Pending in sense of "we are working on it" or in the sense of
>> "exists-but-not-published".
>
> The final fix is trivial and identified, so I guess that Clément has yet
> had time to send the patch.
>
>> I did not found a hint on the offline linux-kbuild ML.
>
> That would be Michal's suggestion there:
> http://marc.info/?l=linux-kbuild&m=137907001305533&w=2
>
I talked with Thorsten (MirBSD and Debian developer) and he suggested:
$ sed -e "s^A$before^A$after^A" "$infile" >"$tmpfile" <--- see
attached Text-File
NOTE: Control character "^A" <--- ASCII 0x01 aka SOH (Start Of Heading)
- Sedat -
P.S.: Note2myself: vi/vim: Insert-mode: Ctrl-v Ctrl-a
>> BTW, the GIT repo of Yann is not browsable (which is sh*t for checking
>> commits quickl, I don't want to be forced to checkout).
>
> Yes, I know about that one. I've already notified the gitorious guys
> about the issue, they supposedly fixed it, but it is broken again.
>
> I will re-open my ticket in a moment.
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'