2013-09-27 18:28:32

by Ondrej Zary

Subject: [PATCH 2/2] [RESEND] snd-ac97-codec: Use complete ID when the codec is not known

Currently, if the codec ID is not known, the last byte of the ID is used as name.
It's not helpful at all, use full codec ID instead.

Signed-off-by: Ondrej Zary <[email protected]>
---
sound/pci/ac97/ac97_codec.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
index bf578ba2..30a40a8 100644
--- a/sound/pci/ac97/ac97_codec.c
+++ b/sound/pci/ac97/ac97_codec.c
@@ -1830,7 +1830,7 @@ void snd_ac97_get_name(struct snd_ac97 *ac97, unsigned int id, char *name, int m
pid->patch(ac97);
}
} else
- sprintf(name + strlen(name), " id %x", id & 0xff);
+ sprintf(name + strlen(name), " id %x", id);
}

/**
--
Ondrej Zary

2013-09-30 09:06:19

by Takashi Iwai

Subject: Re: [alsa-devel] [PATCH 2/2] [RESEND] snd-ac97-codec: Use complete ID when the codec is not known

At Fri, 27 Sep 2013 20:28:03 +0200,
Ondrej Zary wrote:
>
> Currently, if the codec ID is not known, the last byte of the ID is used as name.
> It's not helpful at all, use full codec ID instead.

The full bytes are already shown at the beginning, no?
It's masked because the upper three bytes are shown in printable form,
and the last byte is usually a model number.


Takashi

>
> Signed-off-by: Ondrej Zary <[email protected]>
> ---
> sound/pci/ac97/ac97_codec.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
> index bf578ba2..30a40a8 100644
> --- a/sound/pci/ac97/ac97_codec.c
> +++ b/sound/pci/ac97/ac97_codec.c
> @@ -1830,7 +1830,7 @@ void snd_ac97_get_name(struct snd_ac97 *ac97, unsigned int id, char *name, int m
> pid->patch(ac97);
> }
> } else
> - sprintf(name + strlen(name), " id %x", id & 0xff);
> + sprintf(name + strlen(name), " id %x", id);
> }
>
> /**
> --
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> [email protected]
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>

2013-09-30 18:42:29

by Ondrej Zary

Subject: Re: [alsa-devel] [PATCH 2/2] [RESEND] snd-ac97-codec: Use complete ID when the codec is not known

On Monday 30 September 2013 11:08:50 Takashi Iwai wrote:
> At Fri, 27 Sep 2013 20:28:03 +0200,
>
> Ondrej Zary wrote:
> > Currently, if the codec ID is not known, the last byte of the ID is used
> > as name. It's not helpful at all, use full codec ID instead.
>
> The full bytes are already shown at the beginning, no?
> It's masked because the upper three bytes are shown in printable form,
> and the last byte is usually a model number.

Thanks, I see now. So this patch is not needed.

>
> Takashi
>
> > Signed-off-by: Ondrej Zary <[email protected]>
> > ---
> > sound/pci/ac97/ac97_codec.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
> > index bf578ba2..30a40a8 100644
> > --- a/sound/pci/ac97/ac97_codec.c
> > +++ b/sound/pci/ac97/ac97_codec.c
> > @@ -1830,7 +1830,7 @@ void snd_ac97_get_name(struct snd_ac97 *ac97,
> > unsigned int id, char *name, int m pid->patch(ac97);
> > }
> > } else
> > - sprintf(name + strlen(name), " id %x", id & 0xff);
> > + sprintf(name + strlen(name), " id %x", id);
> > }
> >
> > /**
> > --
> > Ondrej Zary
> > _______________________________________________
> > Alsa-devel mailing list
> > [email protected]
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
> _______________________________________________
> Alsa-devel mailing list
> [email protected]
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


--
Ondrej Zary