2013-09-30 06:59:13

by Michal Simek

[permalink] [raw]
Subject: [PATCH] amba: Ensure drvdata is NULL


Attachments:
(No filename) (7.14 kB)
(No filename) (198.00 B)
Download all attachments

2013-10-02 20:25:48

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: [PATCH] amba: Ensure drvdata is NULL

On Mon, Sep 30, 2013 at 08:59:06AM +0200, Michal Simek wrote:
> This patch is inpired by the patch for drvdata
> "device-core: Ensure drvdata = NULL when no driver is bound"
> (sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d)
>
> Also it fixes all occurences in drivers.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
> This patch has been sent as RFC in this thread.
> http://lkml.org/lkml/2013/9/4/393

Why not have the driver core do this? Then it gets applied to all bus
types uniformly.

Thanks.

2013-10-03 09:14:34

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH] amba: Ensure drvdata is NULL

On 10/02/2013 10:25 PM, Russell King - ARM Linux wrote:
> On Mon, Sep 30, 2013 at 08:59:06AM +0200, Michal Simek wrote:
>> This patch is inpired by the patch for drvdata
>> "device-core: Ensure drvdata = NULL when no driver is bound"
>> (sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d)
>>
>> Also it fixes all occurences in drivers.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>> ---
>> This patch has been sent as RFC in this thread.
>> http://lkml.org/lkml/2013/9/4/393
>
> Why not have the driver core do this? Then it gets applied to all bus
> types uniformly.

ok - I have checked that path and it should be already done
in really_probe function which calls amba_probe() and then driver probe function.

It means that the patch should contain just "amba_set_drvdata(dev, NULL);"
removal and not touching bus.c file.

Thanks,
Michal