From: Martin Walch <[email protected]>
Date: Wed, 2 Oct 2013 06:58:46 +0200
Subject: [PATCH 4/4] kconfig: remove unused definition from scanner
The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.
Signed-off-by: Martin Walch <[email protected]>
---
scripts/kconfig/zconf.l | 1 -
1 file changed, 1 deletion(-)
diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
index 6555a47..1a9f53e 100644
--- a/scripts/kconfig/zconf.l
+++ b/scripts/kconfig/zconf.l
@@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
}
%}
-ws [ \n\t]
n [A-Za-z0-9_]
%%
--
1.8.1.5
Martin, All,
On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
> Martin Walch <[email protected]> writes:
>
> > From: Martin Walch <[email protected]>
> > Date: Wed, 2 Oct 2013 06:58:46 +0200
> > Subject: [PATCH 4/4] kconfig: remove unused definition from scanner
> >
> > The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.
>
> Hi Martin,
>
> I think you should also regenerate the scanner and add
> the new zconf.lex.c_shipped to this patch.
I think sending the re-generated parser as a separate patch helps
in reviewing. Ie. I'd prefer a fifth patch.
BTW, regenerating the parser can be done with:
make REGENERATE_PARSERS=1 config
Regards,
Yann E. MORIN.
> > Signed-off-by: Martin Walch <[email protected]>
> > ---
> > scripts/kconfig/zconf.l | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
> > index 6555a47..1a9f53e 100644
> > --- a/scripts/kconfig/zconf.l
> > +++ b/scripts/kconfig/zconf.l
> > @@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
> > }
> > %}
> >
> > -ws [ \n\t]
> > n [A-Za-z0-9_]
> >
> > %%
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'
Martin Walch <[email protected]> writes:
> From: Martin Walch <[email protected]>
> Date: Wed, 2 Oct 2013 06:58:46 +0200
> Subject: [PATCH 4/4] kconfig: remove unused definition from scanner
>
> The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.
Hi Martin,
I think you should also regenerate the scanner and add
the new zconf.lex.c_shipped to this patch.
Dirk
> Signed-off-by: Martin Walch <[email protected]>
> ---
> scripts/kconfig/zconf.l | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
> index 6555a47..1a9f53e 100644
> --- a/scripts/kconfig/zconf.l
> +++ b/scripts/kconfig/zconf.l
> @@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
> }
> %}
>
> -ws [ \n\t]
> n [A-Za-z0-9_]
>
> %%
On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote:
> On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
> > I think you should also regenerate the scanner and add
> > the new zconf.lex.c_shipped to this patch.
>
> I think sending the re-generated parser as a separate patch helps
> in reviewing. Ie. I'd prefer a fifth patch.
>
> BTW, regenerating the parser can be done with:
> make REGENERATE_PARSERS=1 config
Actually, I regenerated the scanner. However, the results did not change
after applying the patch, because the definition that the patch removes
(ws) is not used anywhere. It is only a cleanup.
Regenerating the scanner and the parser code with newer versions of
flex and bison results in code changes. However, they are not related to
the patch, but originate from updates in flex and bison.
Therefore I did not see any point in including the regenerated files in
this patch set.
Of course, if you see any benefit in regenerating the *_shipped files, I can
still do so.
Regards,
Martin Walch
--
Martin, All,
On Thursday 03 October 2013 02:30:21 Martin Walch wrote:
> On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote:
> > On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
> > > I think you should also regenerate the scanner and add
> > > the new zconf.lex.c_shipped to this patch.
> >
> > I think sending the re-generated parser as a separate patch helps
> > in reviewing. Ie. I'd prefer a fifth patch.
> >
> > BTW, regenerating the parser can be done with:
> > make REGENERATE_PARSERS=1 config
>
> Actually, I regenerated the scanner. However, the results did not change
> after applying the patch, because the definition that the patch removes
> (ws) is not used anywhere. It is only a cleanup.
OK, then please say so in the commit message.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'