Hi,
With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB
(peripheral, g_ether).
According to git bisect this is caused by:
9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 is the first bad commit
commit 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61
Author: Bin Liu <[email protected]>
Date: Tue Sep 17 15:33:35 2013 -0500
usb: musb: gadget: fix otg active status flag
In gadget mode, musb->is_active should be set only when connected to the
host. musb_g_reset() already takes care of it.
Signed-off-by: Bin Liu <[email protected]>
Signed-off-by: Felipe Balbi <[email protected]>
Reverting that commit from v3.12-rc4 will fix the issue. Based on the
commit log this is not fixing any real issue, so I wonder why was it
included in -rc4 in the first place?
A.
Hi,
On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote:
> With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB
> (peripheral, g_ether).
To clarify, I was running v3.12-rc4 on N800/peripheral side and that's
where the problem is; on host side I'm running some old Debian kernel.
A.
On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote:
> Hi,
>
> With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB
> (peripheral, g_ether).
>
> According to git bisect this is caused by:
>
> 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 is the first bad commit
> commit 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61
> Author: Bin Liu <[email protected]>
> Date: Tue Sep 17 15:33:35 2013 -0500
>
> usb: musb: gadget: fix otg active status flag
>
> In gadget mode, musb->is_active should be set only when connected to the
> host. musb_g_reset() already takes care of it.
>
> Signed-off-by: Bin Liu <[email protected]>
> Signed-off-by: Felipe Balbi <[email protected]>
>
> Reverting that commit from v3.12-rc4 will fix the issue. Based on the
> commit log this is not fixing any real issue, so I wonder why was it
> included in -rc4 in the first place?
Hm, Felipe, should I just revert this patch for 3.12-final?
thanks,
greg k-h
Hi,
On Mon, Oct 14, 2013 at 08:33:56AM -0700, Greg Kroah-Hartman wrote:
> On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote:
> > Hi,
> >
> > With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB
> > (peripheral, g_ether).
> >
> > According to git bisect this is caused by:
> >
> > 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 is the first bad commit
> > commit 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61
> > Author: Bin Liu <[email protected]>
> > Date: Tue Sep 17 15:33:35 2013 -0500
> >
> > usb: musb: gadget: fix otg active status flag
> >
> > In gadget mode, musb->is_active should be set only when connected to the
> > host. musb_g_reset() already takes care of it.
> >
> > Signed-off-by: Bin Liu <[email protected]>
> > Signed-off-by: Felipe Balbi <[email protected]>
> >
> > Reverting that commit from v3.12-rc4 will fix the issue. Based on the
> > commit log this is not fixing any real issue, so I wonder why was it
> > included in -rc4 in the first place?
>
> Hm, Felipe, should I just revert this patch for 3.12-final?
Yeah, let's do that... It's unfortunate that tusb6010 is so messed up
:-(
--
balbi
On Mon, Oct 14, 2013 at 02:05:39PM -0500, Felipe Balbi wrote:
> Hi,
>
> On Mon, Oct 14, 2013 at 08:33:56AM -0700, Greg Kroah-Hartman wrote:
> > On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote:
> > > Hi,
> > >
> > > With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB
> > > (peripheral, g_ether).
> > >
> > > According to git bisect this is caused by:
> > >
> > > 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 is the first bad commit
> > > commit 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61
> > > Author: Bin Liu <[email protected]>
> > > Date: Tue Sep 17 15:33:35 2013 -0500
> > >
> > > usb: musb: gadget: fix otg active status flag
> > >
> > > In gadget mode, musb->is_active should be set only when connected to the
> > > host. musb_g_reset() already takes care of it.
> > >
> > > Signed-off-by: Bin Liu <[email protected]>
> > > Signed-off-by: Felipe Balbi <[email protected]>
> > >
> > > Reverting that commit from v3.12-rc4 will fix the issue. Based on the
> > > commit log this is not fixing any real issue, so I wonder why was it
> > > included in -rc4 in the first place?
> >
> > Hm, Felipe, should I just revert this patch for 3.12-final?
>
> Yeah, let's do that... It's unfortunate that tusb6010 is so messed up
> :-(
Ok, now reverted.