2014-04-25 20:11:23

by Fabian Frédérick

[permalink] [raw]
Subject: [PATCH 1/1] drivers/scsi/sd.c: remove positive test on unsigned value

val is unsigned.

Cc: "James E.J. Bottomley" <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/scsi/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index efcbcd1..b54d4f8 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -296,7 +296,7 @@ protection_type_store(struct device *dev, struct device_attribute *attr,
if (err)
return err;

- if (val >= 0 && val <= SD_DIF_TYPE3_PROTECTION)
+ if (val <= SD_DIF_TYPE3_PROTECTION)
sdkp->protection_type = val;

return count;
--
1.8.4.5