2014-07-06 15:36:01

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: [PATCH] machine_power_off: not only local_irq_disable but also do disable preemption

On Sun, Jul 06, 2014 at 08:20:36PM +0530, pawandeep oza wrote:
> just to add to this,
> this scenerio happened on the platform which I am working on,
> where interrupts were being re-enabled in rpm_callback path...because the

Can you explain how you get to the runtime callback paths from the
system reboot/shutdown handlers?

In any case, calling the plain _irq (rather than _irqsave) variants of
spinlocks when IRQs are already disabled is (another) bug. The plain
_irq variants are not permitted when IRQs have been previously
disabled.

--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.