2015-02-01 19:30:18

by Jeremiah Mahler

[permalink] [raw]
Subject: Re: [BUG, bisect] hang when copying large file to disc

Ted,

On Sat, Jan 31, 2015 at 09:02:30PM -0500, Theodore Ts'o wrote:
> On Fri, Jan 30, 2015 at 07:40:51PM -0800, Jeremiah Mahler wrote:
> >
[...]
>
> Thanks for the bug report. I was able to reproduce the problem, and
> found the problem. Unfortunately I accidentally introduce this in my
> most recent patchset. I'll fix it up, but here is the patch until I
> get the a new version pushed out.
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 82c2984..0046861 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -1192,9 +1192,9 @@ void __mark_inode_dirty(struct inode *inode, int flags)
>
> trace_writeback_dirty_inode(inode, flags);
> }
> - dirtytime = flags & I_DIRTY_TIME;
> if (flags & I_DIRTY_INODE)
> flags &= ~I_DIRTY_TIME;
> + dirtytime = flags & I_DIRTY_TIME;
>
> /*
> * Paired with smp_mb() in __writeback_single_inode() for the
>
> - Ted

That solved the problem. Thanks for the quick fix.

--
- Jeremiah Mahler