2015-04-02 03:55:39

by Fam Zheng

[permalink] [raw]
Subject: Re: [PATCH v5 06/10] virtio_pci: drop msi_off on probe

On Sun, 03/29 17:04, Michael S. Tsirkin wrote:
> pci core now disables msi on probe automatically,
> drop this from device-specific code.
>
> Cc: Bjorn Helgaas <[email protected]>
> Cc: [email protected]
> Signed-off-by: Michael S. Tsirkin <[email protected]>
> ---
> drivers/virtio/virtio_pci_common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
> index e894eb2..806bb2c 100644
> --- a/drivers/virtio/virtio_pci_common.c
> +++ b/drivers/virtio/virtio_pci_common.c
> @@ -501,9 +501,6 @@ static int virtio_pci_probe(struct pci_dev *pci_dev,
> INIT_LIST_HEAD(&vp_dev->virtqueues);
> spin_lock_init(&vp_dev->lock);
>
> - /* Disable MSI/MSIX to bring device to a known good state. */
> - pci_msi_off(pci_dev);
> -
> /* enable the device */
> rc = pci_enable_device(pci_dev);
> if (rc)
> --
> MST
>

Reviewed-by: Fam Zheng <[email protected]>