2015-06-08 21:49:45

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

Hi Joe,

On Sun, May 31, 2015 at 05:44:45PM -0700, Joe Perches wrote:
> Several of these goto exit; uses should be direct returns
> as skb is not yet initialized by nci_hci_get_param().
>
> Miscellanea:
>
> o Use !memcmp instead of memcmp() == 0
> o Remove unnecessary goto from if () {... goto exit;} else {...} exit:
>
> Signed-off-by: Joe Perches <[email protected]>
> ---
> net/nfc/nci/hci.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
Applied to nfc-next, thanks.

Cheers,
Samuel.