2015-06-15 05:05:32

by Maninder Singh

Subject: [PATCH 1/1] net: replace if()/BUG with BUG_ON()

Use BUG_ON(condition) instead of if(condition)/BUG()

Signed-off-by: Maninder Singh <[email protected]>
Reviewed-by: Akhilesh Kumar <[email protected]>
---
net/packet/af_packet.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index b5989c6..c91d405 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -547,8 +547,7 @@ static void prb_setup_retire_blk_timer(struct
packet_sock *po, int tx_ring)
{
struct tpacket_kbdq_core *pkc;

- if (tx_ring)
- BUG();
+ BUG_ON(tx_ring);

pkc = tx_ring ? GET_PBDQC_FROM_RB(&po->tx_ring) :
GET_PBDQC_FROM_RB(&po->rx_ring);
--
1.7.1

2015-06-16 00:12:46

by David Miller

Subject: Re: [PATCH 1/1] net: replace if()/BUG with BUG_ON()

From: Maninder Singh <[email protected]>
Date: Mon, 15 Jun 2015 10:35:05 +0530

> Use BUG_ON(condition) instead of if(condition)/BUG()
>
> Signed-off-by: Maninder Singh <[email protected]>
> Reviewed-by: Akhilesh Kumar <[email protected]>

Your email client corrupted this patch, making it unusable.

2015-06-17 05:04:24

by Maninder Singh

Subject: Re: Re: [PATCH 1/1] net: replace if()/BUG with BUG_ON()

Hi David,

>> Use BUG_ON(condition) instead of if(condition)/BUG()
>>
>> Signed-off-by: Maninder Singh <[email protected]>
>> Reviewed-by: Akhilesh Kumar <[email protected]>

>Your email client corrupted this patch, making it unusable

I resent the patch with git send-mail , it results ok, hopefully it does not corrupt it.

Thanks????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?