2015-06-23 14:20:18

by Luis de Bethencourt

Subject: [PATCH] staging: lustre: mgc: no need to compare bool value

Inverting the value of eof is a more direct way of passing to the debugging
function if eof is false or not.

Signed-off-by: Luis de Bethencourt <[email protected]>
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
index 7947aec..cd3ce40 100644
--- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
+++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
@@ -1406,7 +1406,7 @@ again:
eof = res->mcr_offset == res->mcr_size;

CDEBUG(D_INFO, "Latest version %lld, more %d.\n",
- res->mcr_offset, eof == false);
+ res->mcr_offset, !eof);

ealen = sptlrpc_cli_unwrap_bulk_read(req, req->rq_bulk, 0);
if (ealen < 0) {
--
2.1.4

2015-07-14 02:38:17

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: lustre: mgc: no need to compare bool value

On Tue, Jun 23, 2015 at 04:26:11PM +0200, Luis de Bethencourt wrote:
> Inverting the value of eof is a more direct way of passing to the debugging
> function if eof is false or not.

Really? I like the explicit-ness of the code as it is today, it's more
obvious what is going on, which is the most important thing.

thanks,

greg k-h