2015-07-23 10:52:45

by Suneel Garapati

Subject: [PATCH] devicetree: xilinx: add rtc node to zynqmp dtsi

adds rtc controller node to zynqmp devicetree.

Signed-off-by: Suneel Garapati <[email protected]>
---
arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts | 4 ++++
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 9 +++++++++
2 files changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
index 0a3f40e..b48ce47 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
@@ -45,3 +45,7 @@
&uart0 {
status = "okay";
};
+
+&rtc {
+ status = "okay";
+};
\ No newline at end of file
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index 11e0b00..b76ede1 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
+++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
@@ -220,6 +220,15 @@
#size-cells = <0>;
};

+ rtc: rtc@ffa60000 {
+ compatible = "xlnx,zynqmp-rtc";
+ status = "disabled";
+ reg = <0x0 0xffa60000 0x100>;
+ interrupt-parent = <&gic>;
+ interrupts = <0 26 4>, <0 27 4>;
+ interrupt-names = "alm", "sec";
+ };
+
spi0: spi@ff040000 {
compatible = "cdns,spi-r1p6";
status = "disabled";
--
2.1.2

2015-07-23 13:58:58

by Soren Brinkmann

Subject: Re: [PATCH] devicetree: xilinx: add rtc node to zynqmp dtsi

Hi Suneel,

On Thu, 2015-07-23 at 04:22PM +0530, Suneel Garapati wrote:
> adds rtc controller node to zynqmp devicetree.
>
> Signed-off-by: Suneel Garapati <[email protected]>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts | 4 ++++
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 9 +++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> index 0a3f40e..b48ce47 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> @@ -45,3 +45,7 @@
> &uart0 {
> status = "okay";
> };
> +
> +&rtc {
> + status = "okay";
> +};
> \ No newline at end of file
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 11e0b00..b76ede1 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -220,6 +220,15 @@
> #size-cells = <0>;
> };
>
> + rtc: rtc@ffa60000 {
> + compatible = "xlnx,zynqmp-rtc";
> + status = "disabled";

do we need the status disabled here?

> + reg = <0x0 0xffa60000 0x100>;
> + interrupt-parent = <&gic>;
> + interrupts = <0 26 4>, <0 27 4>;
> + interrupt-names = "alm", "sec";

Descriptive names would be nice. What is 'alm' supposed to mean?

Thanks,
Sören